Skip to content

feat(settings): allow terminal font size down to 8 - #1832

Merged
openwong2kim merged 2 commits into
openwong2kim:mainfrom
bluemas:pr/font-size-8
Oct 6, 2026
Merged

openwong2kim merged 2 commits into
openwong2kim:mainfrom
bluemas:pr/font-size-8

Conversation

@bluemas

@bluemas bluemas commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The terminal font-size slider and keyboard zoom both stopped at 12px, so smaller sizes could not be set. Both now go down to 8px.
  • The two limits stay matched: the slider min and FONT_SIZE_MIN in useKeyboard.ts are both 8.
  • The "range" hint is updated in every locale, and the tests that pinned 12 now expect 8.

Notes

  • Ported from a fork commit onto current main. It applied cleanly.
  • Checked that no other code limits terminalFontSize: the store, persisted-session restore and useTerminal pass the value through unchanged.

Test plan

  • npm run typecheck:quiet: ok (8 slices)
  • npm run test:agent -- src/renderer/hooks/__tests__/useKeyboard src/renderer/components/Settings/__tests__ src/renderer/i18n/__tests__: 50 files, 627 tests passed

🤖 Generated with Claude Code

bluemas and others added 2 commits October 7, 2026 03:21
The font-size slider and the keyboard zoom both clamped at 12, so smaller
sizes could not be set. Lower the minimum to 8 in both places, and update
the "range" hint in every locale and the tests that pinned 12.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0e252a18-bf59-4862-a153-272dadcbc5bf
📥 Commits

Reviewing files that changed from the base of the PR and between 1325115 and 21ef64e.

📒 Files selected for processing (28)
  • changelog.d/1832.md
  • src/renderer/components/Settings/SettingsPanel.tsx
  • src/renderer/hooks/__tests__/useKeyboard.test.ts
  • src/renderer/hooks/__tests__/useKeyboard.zoom.dynamic.test.tsx
  • src/renderer/hooks/useKeyboard.ts
  • src/renderer/i18n/locales/ar.ts
  • src/renderer/i18n/locales/bs.ts
  • src/renderer/i18n/locales/da.ts
  • src/renderer/i18n/locales/de.ts
  • src/renderer/i18n/locales/en.ts
  • src/renderer/i18n/locales/es.ts
  • src/renderer/i18n/locales/fr.ts
  • src/renderer/i18n/locales/hi.ts
  • src/renderer/i18n/locales/id.ts
  • src/renderer/i18n/locales/it.ts
  • src/renderer/i18n/locales/ja.ts
  • src/renderer/i18n/locales/ko.ts
  • src/renderer/i18n/locales/ms.ts
  • src/renderer/i18n/locales/nb.ts
  • src/renderer/i18n/locales/pl.ts
  • src/renderer/i18n/locales/pt-BR.ts
  • src/renderer/i18n/locales/ru.ts
  • src/renderer/i18n/locales/th.ts
  • src/renderer/i18n/locales/tr.ts
  • src/renderer/i18n/locales/uk.ts
  • src/renderer/i18n/locales/vi.ts
  • src/renderer/i18n/locales/zh-TW.ts
  • src/renderer/i18n/locales/zh.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openwong2kim
openwong2kim merged commit a13ed6c into openwong2kim:main Oct 6, 2026
10 checks passed
bluemas added a commit to bluemas/wmux that referenced this pull request Oct 6, 2026
Brings in openwong2kim#1819, openwong2kim#1820, openwong2kim#1840 and openwong2kim#1841. openwong2kim#1832-openwong2kim#1834 and openwong2kim#1836 are the
fork's own changes squash-merged upstream; they add only their changelog
fragments here.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants