Repository navigation
feat(settings): allow terminal font size down to 8 - #1832
Merged
Merged
Conversation
The font-size slider and the keyboard zoom both clamped at 12, so smaller sizes could not be set. Lower the minimum to 8 in both places, and update the "range" hint in every locale and the tests that pinned 12. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (28)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bluemas
added a commit
to bluemas/wmux
that referenced
this pull request
Oct 6, 2026
Brings in openwong2kim#1819, openwong2kim#1820, openwong2kim#1840 and openwong2kim#1841. openwong2kim#1832-openwong2kim#1834 and openwong2kim#1836 are the fork's own changes squash-merged upstream; they add only their changelog fragments here. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minandFONT_SIZE_MINinuseKeyboard.tsare both 8.Notes
main. It applied cleanly.terminalFontSize: the store, persisted-session restore anduseTerminalpass the value through unchanged.Test plan
npm run typecheck:quiet: ok (8 slices)npm run test:agent -- src/renderer/hooks/__tests__/useKeyboard src/renderer/components/Settings/__tests__ src/renderer/i18n/__tests__: 50 files, 627 tests passed🤖 Generated with Claude Code