Repository navigation
test: execute disabled usage preference persistence - #1819
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe session-save test now executes the production builder and verifies that the Anthropic usage setting survives JSON serialization. A usage-poller comment now names the ChangesSession-save invariant test
Usage-poller comment
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change strengthens session-save coverage and updates a poller comment; no merge-blocking behavior or operational issue is established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Brings in openwong2kim#1819, openwong2kim#1820, openwong2kim#1840 and openwong2kim#1841. openwong2kim#1832-openwong2kim#1834 and openwong2kim#1836 are the fork's own changes squash-merged upstream; they add only their changelog fragments here. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Summary
Execute the save-side coverage requested after #906: both enabled and disabled
usage preferences must survive session JSON serialization.
Changes
buildSessionDatafunction from AppLayoutfor the existing test harness, then assert that its serialized output owns
anthropicUsageEnabledwith the exacttrueorfalsevalue.UsagePoller.start()/stop()in the hydration comment, matching theexisting IPC toggle implementation and its idempotent lifecycle methods.
CHANGELOG entry
no CHANGELOG — internal only; tests and a source comment.
Stability tier impact
Substrate contract impact (Substrate 3.0)
n/a
Test plan
npm run typecheck:quietpassed.npm testpassed in an isolated Linux container: 1,670 parallel testfiles and 22 runtime test files passed; 4 parallel and 11 runtime files were
skipped by their existing platform/environment guards.
for runtime tests. No manual UI verification was performed.
Related issues / PRs
Follow-up to #906, covering the two optional review notes.
Reviewer checklist
.env, or unrelated large binaries.Summary by CodeRabbit