perf(vm): avoid zeroed allocation in BasicMemory::clone#2352
Merged
jonathanpwang merged 1 commit intoopenvm-org:mainfrom Jan 31, 2026
Merged
Conversation
jonathanpwang
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
alloc_zeroedwithallocinBasicMemory::cloneto avoid unnecessary zero-initialization before copying the existing contents. The clone path always overwrites the entire allocated region withcopy_nonoverlapping, so zeroing first provides no safety benefit but doubles the amount of memory work for large buffers. The constructor still usesalloc_zeroedto preserve the invariant that freshly created linear memory starts zeroed.