Skip to content

[IE CLDNN] Enable I64 const inputs for batch_to_space#860

Merged
vladimir-paramuzov merged 1 commit intoopenvinotoolkit:masterfrom
jhajducz:private/jhajducz/batch_to_space_i64_fix
Jun 10, 2020
Merged

[IE CLDNN] Enable I64 const inputs for batch_to_space#860
vladimir-paramuzov merged 1 commit intoopenvinotoolkit:masterfrom
jhajducz:private/jhajducz/batch_to_space_i64_fix

Conversation

@jhajducz
Copy link
Copy Markdown
Contributor

@jhajducz jhajducz commented Jun 10, 2020 •
edited
Loading

This patch adds missing support for I64 const inputs for recently introduced batch_to_space operation.

@jhajducz jhajducz added the category: GPU OpenVINO GPU plugin label Jun 10, 2020
@jhajducz jhajducz added this to the 2021.1 milestone Jun 10, 2020
@jhajducz jhajducz requested review from a team as code owners June 10, 2020 11:49
@ilya-lavrenov
Copy link
Copy Markdown
Contributor

ilya-lavrenov commented Jun 10, 2020

@jhajducz can it fix smoke_CLDNN/BatchToSpaceLayerTest.CompareWithRefs tests? Currently they fail with

2020-06-10T08:51:16.535Z] [2020-06-10 08:51:16,647] gpuFuncTests INFO: [ RUN      ] smoke_CLDNN/BatchToSpaceLayerTest.CompareWithRefs/IS=(4.1.1.1)_netPRC=FP32_BS=(1.1.2.2)_CB=(0.0.0.0)_CE=(0.0.0.0)_targetDevice=GPU_

[2020-06-10T08:51:16.822Z] [2020-06-10 08:51:16,897] gpuFuncTests INFO: bash: line 1:   904 Floating point exception(core dumped) ./gpuFuncTests --gtest_print_time=1 --gtest_output=xml:/home/jenkins/agent/workspace/private-ci/ie/ie-tests-linux-ubuntu16-gpu/b/logs/gpu_new_func/gpuFuncTests.xml

[2020-06-10T08:51:16.822Z] [2020-06-10 08:51:16,897] gpuFuncTests INFO: ========== Completed. Exit code: 136

@jhajducz
Copy link
Copy Markdown
Contributor Author

jhajducz commented Jun 10, 2020

@jhajducz can it fix smoke_CLDNN/BatchToSpaceLayerTest.CompareWithRefs tests? Currently they fail with

2020-06-10T08:51:16.535Z] [2020-06-10 08:51:16,647] gpuFuncTests INFO: [ RUN      ] smoke_CLDNN/BatchToSpaceLayerTest.CompareWithRefs/IS=(4.1.1.1)_netPRC=FP32_BS=(1.1.2.2)_CB=(0.0.0.0)_CE=(0.0.0.0)_targetDevice=GPU_

[2020-06-10T08:51:16.822Z] [2020-06-10 08:51:16,897] gpuFuncTests INFO: bash: line 1:   904 Floating point exception(core dumped) ./gpuFuncTests --gtest_print_time=1 --gtest_output=xml:/home/jenkins/agent/workspace/private-ci/ie/ie-tests-linux-ubuntu16-gpu/b/logs/gpu_new_func/gpuFuncTests.xml

[2020-06-10T08:51:16.822Z] [2020-06-10 08:51:16,897] gpuFuncTests INFO: ========== Completed. Exit code: 136

Yes, this is exactly how I found it's missing.

@vladimir-paramuzov vladimir-paramuzov mentioned this pull request Jun 10, 2020
Merged
@vladimir-paramuzov vladimir-paramuzov mentioned this pull request Jun 10, 2020
Merged
@ilya-lavrenov ilya-lavrenov added the bug Something isn't working label Jun 10, 2020
@vladimir-paramuzov
Copy link
Copy Markdown

vladimir-paramuzov commented Jun 10, 2020

@ilya-lavrenov batch to space test passed on this branch, but we have fail on windows:

nightly_IEClassCommon/IEClassBasicTestP.smoke_registerPluginsXMLUnicodePath/0
[2020-06-10T13:39:26.528Z] [2020-06-10 16:39:26,444] ClDnnFunctionalTests INFO: openvino\inference-engine\tests_deprecated\functional\shared_tests\ie_class\ie_class.hpp(191): error: Failed
[2020-06-10T13:39:26.528Z] [2020-06-10 16:39:26,447] ClDnnFunctionalTests INFO: [  FAILED  ] nightly_IEClassCommon/IEClassBasicTestP.smoke_registerPluginsXMLUnicodePath/0, where GetParam() = ("clDNNPlugin", "GPU") (0 ms)

I doubt that it's connected with the changes here. @ababushk Could you have a look?

@ababushk
Copy link
Copy Markdown
Contributor

ababushk commented Jun 10, 2020

@vladimir-paramuzov it doesn't connected indeed, master is affected. I'll send you details in e-mail

@vladimir-paramuzov vladimir-paramuzov merged commit 4fbec25 into openvinotoolkit:master Jun 10, 2020
admitriev-gna pushed a commit to admitriev-gna/openvino that referenced this pull request Jun 11, 2020
@jhajducz @admitriev-gna
[IE CLDNN] Enable I64 const inputs for batch_to_space (openvinotoolki…
9dd0f02 
…t#860)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vladimir-paramuzov vladimir-paramuzov vladimir-paramuzov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working category: GPU OpenVINO GPU plugin

Projects

None yet

Milestone

2021.1

Development

Successfully merging this pull request may close these issues.

4 participants

@jhajducz @ilya-lavrenov @vladimir-paramuzov @ababushk