Skip to content

[GNA] Added test ScaleShift and fixed power layer with non zero shift#774

Merged
esmirno merged 2 commits intoopenvinotoolkit:masterfrom
admitriev-gna:private/ad/power-layer-nonzero-shift
Jun 16, 2020
Merged

[GNA] Added test ScaleShift and fixed power layer with non zero shift#774
esmirno merged 2 commits intoopenvinotoolkit:masterfrom
admitriev-gna:private/ad/power-layer-nonzero-shift

Conversation

@admitriev-gna
Copy link
Copy Markdown
Contributor

@admitriev-gna admitriev-gna commented Jun 4, 2020 •
edited
Loading

Added test ScaleShift and fixed power layer with non zero shift

@admitriev-gna admitriev-gna requested review from a team, dorloff, esmirno and pavel-rodionov June 4, 2020 12:44
@admitriev-gna admitriev-gna force-pushed the private/ad/power-layer-nonzero-shift branch 2 times, most recently from dd97a79 to b64192d Compare June 5, 2020 07:59
@admitriev-gna
Copy link
Copy Markdown
Contributor Author

admitriev-gna commented Jun 5, 2020

@dorloff , @esmirno, @pavel-rodionov check please.

@admitriev-gna admitriev-gna added the category: GNA OpenVINO GNA plugin label Jun 5, 2020
mikhail-treskin
mikhail-treskin suggested changes Jun 5, 2020
View reviewed changes
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/scale_shift.cpp Outdated
Copy link
Copy Markdown

@mikhail-treskin mikhail-treskin Jun 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the IE perspective, it is actually a single layer graph, but in fact, we strive to keep single layer tests with only one ngraph op. Let's name them "single operation" from the opset specification perspective.

Since you are implementing chain of operation (despite of them will be folded to one ScaleShift layer in IE representation) I request to move such test shared subgraph_tests

@admitriev-gna admitriev-gna force-pushed the private/ad/power-layer-nonzero-shift branch 3 times, most recently from 76f1f6b to 81510c0 Compare June 8, 2020 05:54
esmirno
esmirno requested changes Jun 9, 2020
View reviewed changes
@admitriev-gna admitriev-gna requested a review from esmirno June 11, 2020 08:25
esmirno
esmirno requested changes Jun 11, 2020
View reviewed changes
@admitriev-gna admitriev-gna force-pushed the private/ad/power-layer-nonzero-shift branch 2 times, most recently from a39eb1d to d353c29 Compare June 11, 2020 16:27
@esmirno
Copy link
Copy Markdown
Contributor

esmirno commented Jun 11, 2020

was testAssert passed validation?

@admitriev-gna
Copy link
Copy Markdown
Contributor Author

admitriev-gna commented Jun 11, 2020

@esmirno, Yes, testAssert passed.

@esmirno
Copy link
Copy Markdown
Contributor

esmirno commented Jun 11, 2020 •
edited
Loading

@admitriev-gna cool, so lets use naming like quantizedWeights, weights, or powerWeights since it is not an identity as i pointed previously. or better quantizedScale, and quantizedOffset

@admitriev-gna admitriev-gna force-pushed the private/ad/power-layer-nonzero-shift branch from d353c29 to 116394b Compare June 11, 2020 19:13
@admitriev-gna admitriev-gna requested review from a team June 11, 2020 19:13
@admitriev-gna admitriev-gna requested review from a team as code owners June 11, 2020 19:13
@admitriev-gna admitriev-gna requested a review from a team June 11, 2020 19:13
@admitriev-gna admitriev-gna requested a review from a team as a code owner June 11, 2020 19:13
@admitriev-gna admitriev-gna requested review from a team June 11, 2020 19:13
@esmirno
Copy link
Copy Markdown
Contributor

esmirno commented Jun 11, 2020

should be only 2 comits not 13 please figure out - probably originate branch should be rebased

@admitriev-gna admitriev-gna force-pushed the private/ad/power-layer-nonzero-shift branch from 116394b to 5554627 Compare June 14, 2020 10:15
@admitriev-gna admitriev-gna requested a review from a team June 14, 2020 10:15
@admitriev-gna admitriev-gna force-pushed the private/ad/power-layer-nonzero-shift branch from 5554627 to b51acc2 Compare June 14, 2020 10:20
@admitriev-gna
[GNA] Added test ScaleShift and fixed power layer with non zero shift
2fbed77 
added tests

[GNA] Added test ScaleShift and fixed power layer with non zero shift
@admitriev-gna
Test Assert
9c073e8
@admitriev-gna admitriev-gna force-pushed the private/ad/power-layer-nonzero-shift branch from b51acc2 to 9c073e8 Compare June 14, 2020 10:26
@admitriev-gna admitriev-gna requested review from a team and removed request for a team and GlebKazantaev June 14, 2020 10:36
@esmirno esmirno merged commit 5e165ac into openvinotoolkit:master Jun 16, 2020
@dorloff dorloff mentioned this pull request Jun 16, 2020
Closed
tadamowicz pushed a commit to tadamowicz/openvino that referenced this pull request Aug 30, 2023
@admitriev-gna @dood-apo
[GNA] Added test ScaleShift and fixed power layer with non zero shift (…
85f320d 
…openvinotoolkit#774)

* [GNA] Added test ScaleShift and fixed power layer with non zero shift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esmirno esmirno esmirno approved these changes

@pavel-rodionov pavel-rodionov Awaiting requested review from pavel-rodionov

@dorloff dorloff Awaiting requested review from dorloff

+1 more reviewer

@mikhail-treskin mikhail-treskin mikhail-treskin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: GNA OpenVINO GNA plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@admitriev-gna @esmirno @mikhail-treskin