Skip to content

Fix onnx slice by clipping "ends" to int32 domain#603

Merged
lazarevevgeny merged 1 commit intoopenvinotoolkit:masterfrom
mvafin:fix/onnx-slice
Jun 9, 2020
Merged

Fix onnx slice by clipping "ends" to int32 domain#603
lazarevevgeny merged 1 commit intoopenvinotoolkit:masterfrom
mvafin:fix/onnx-slice

Conversation

@mvafin
Copy link
Copy Markdown
Contributor

@mvafin mvafin commented May 26, 2020

No description provided.

@mvafin mvafin added the category: MO Model Optimizer label May 26, 2020
@mvafin mvafin requested a review from a team May 26, 2020 13:52
@e-nugmanova
Copy link
Copy Markdown
Contributor

e-nugmanova commented May 26, 2020

stress tests failed due to master issues. please wait for #602 to be merged. and then update the branch

@lazarevevgeny lazarevevgeny self-requested a review May 28, 2020 07:44
Copy link
Copy Markdown
Contributor

@lazarevevgeny lazarevevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not merge this PR until we have e2e model running. Right now we see a shape mismatch in the nGraph.

@mvafin mvafin requested a review from a team June 8, 2020 12:39
@lazarevevgeny lazarevevgeny requested a review from e-nugmanova June 9, 2020 04:52
@mvafin
Copy link
Copy Markdown
Contributor Author

mvafin commented Jun 9, 2020

Reverted changes in ngraph. Isolating this PR to MO only.

@e-nugmanova
Copy link
Copy Markdown
Contributor

This change my affect theoretical cases (for example from conformance testing suite) where we will cut off less.

@lazarevevgeny lazarevevgeny merged commit 074266b into openvinotoolkit:master Jun 9, 2020
admitriev-gna pushed a commit to admitriev-gna/openvino that referenced this pull request Jun 11, 2020
@mvafin mvafin deleted the fix/onnx-slice branch February 9, 2023 18:24
redradist pushed a commit to redradist/openvino that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: MO Model Optimizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants