[IE CLDNN] Add support for I64 data type in clDNN plugin#555
Merged
vladimir-paramuzov merged 16 commits intoopenvinotoolkit:masterfrom Jun 10, 2020
jhajducz:feature/jhajducz/int64
Merged
[IE CLDNN] Add support for I64 data type in clDNN plugin#555vladimir-paramuzov merged 16 commits intoopenvinotoolkit:masterfrom jhajducz:feature/jhajducz/int64
vladimir-paramuzov merged 16 commits intoopenvinotoolkit:masterfrom
jhajducz:feature/jhajducz/int64
Conversation
vladimir-paramuzov
left a comment
vladimir-paramuzov
left a comment
There was a problem hiding this comment.
Looks good to me in general. The only concern is that MR doesn't have any tests. Do we already have some functional tests for I64 input type?
Contributor
Author
I've enabled I64 data type in existing functional tests and extended I64 coverage in clDNN unit tests a bit, hope that's enough. |
vladimir-paramuzov
approved these changes
May 29, 2020
Contributor
Author
|
Looks that there is some problem with StridedSlice functional test, I'll have to dig a bit more to find out what's going on. |
admitriev-gna
pushed a commit
to admitriev-gna/openvino
that referenced
this pull request
Jun 11, 2020
redradist
pushed a commit
to redradist/openvino
that referenced
this pull request
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this moment we do i64,u64 -> i32 conversion for the whole network in the plugin and it might not work well if model has i64 input or output (data types in original network and type expected by the plugin might mismatch). This change it meant to add i64/u64 support for dynamic inputs and outputs.
JIRA: CVS-25247