[IE VPU] Set name for output DSR in DTS#1011
Merged
ggladilov merged 4 commits intoopenvinotoolkit:masterfrom Jun 30, 2020
Merged
[IE VPU] Set name for output DSR in DTS#1011ggladilov merged 4 commits intoopenvinotoolkit:masterfrom
ggladilov merged 4 commits intoopenvinotoolkit:masterfrom
Conversation
Maxim-Doronin
requested review from
e-nugmanova and
ggladilov
and removed request for
e-nugmanova and
ggladilov
Maxim-Doronin
force-pushed
the
vpu/md/set_name_to_output_DSR
branch
2 times, most recently
from
86ea1e0 to
2251620
Compare
ggladilov
reviewed
Jun 19, 2020
Contributor
ggladilov
left a comment
ggladilov
left a comment
There was a problem hiding this comment.
LGTM in general, but may be it worthies to check API usage with @GlebKazantaev
Comment on lines
48
to
50
Contributor
There was a problem hiding this comment.
Nitpick: use move semantic here:
auto outDSR = std::make_shared<ngraph::vpu::op::DynamicShapeResolver>(copied, shape);
outDSR->set_friendly_name(eltwise->get_friendly_name());
ngraph::replace_node(std::move(eltwise), std::move(outDSR));
Contributor
There was a problem hiding this comment.
If you agree, probably it is applicable for other places as well
ggladilov
approved these changes
Jun 19, 2020
Maxim-Doronin
force-pushed
the
vpu/md/set_name_to_output_DSR
branch
from
ebc29c3 to
4abff22
Compare
ghost
mentioned this pull request
Maxim-Doronin
force-pushed
the
vpu/md/set_name_to_output_DSR
branch
from
4abff22 to
2851a94
Compare
Maxim-Doronin
force-pushed
the
vpu/md/set_name_to_output_DSR
branch
from
2851a94 to
327a91d
Compare
Contributor
Author
|
@rvyunov, could you review changes, please? |
Contributor
|
It looks good to me 👍 But internal windows validation seems broken. What about it? |
Contributor
Author
It is not a related issue. Nightly validation from master #120 has the same failures. Please, mark this PR as approved if you have no objections. |
rvyunov
approved these changes
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task
#-33722, #-31385