Conversation
Summary of ChangesHello @lukhnos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取請求主要處理垂直候選字選單的兩個相關問題。首先，它修正了候選字清單捲動位置不正確的錯誤，尤其是在聯想詞模組要求顯示第一頁時。其次，它改進了在初始頁面按下「Page Up」鍵時的行為，確保選取能正確地循環到最後一個候選字詞。這些變更旨在提升候選字選取功能的準確性和使用者體驗。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Packages/CandidateUI/Sources/CandidateUI/VerticalCandidateController.swift
Outdated
Show resolved
Hide resolved
This fixes openvanilla#119 This is synced from openvanilla/McBopomofo#755 and a detailed analysis of the changes can be found there.
This fixes the bug where Page Up at index 0 went to the *penultimate* candidate, not the last candidate.
lukhnos
force-pushed
the
candidate-ui-fix
branch
from
052fdc1 to
0b875d1
Compare
2 participants
這個 PR 修正從小麥注音同步來的垂直選字窗所帶來的問題。這一段程式碼是九月時帶進來的。問題出在先前計算翻頁後、table view 要捲動到哪一行的程式，只考慮到連續翻頁的情境──但是 OV 的聯想詞模組直接要求翻到第 0 頁（等於是選取第 0 個候選字詞），結果那一段程式就誤算了 table view 要捲動到的行數，並且讓後續的選字窗狀態連帶錯亂。我們在小麥注音中修正了這一段的計算邏輯，在此同步過來。
這個 PR 同時修正一個無關的問題：選字窗在第 0 頁，按 Page Up 時，選字窗應該倒卷至最後一頁，且高亮選取最後一個候選字詞。但先前的邏輯選到的是倒數第二個候選字詞，而不是最後一個。
Fixes #119