Adding Link research page#253
Conversation
khmakoto
requested review from
gregwhitworth,
levithomason and
una
as code owners
gregwhitworth
left a comment
gregwhitworth
left a comment
There was a problem hiding this comment.
This one raises an interesting point regarding how few actually have their own Link component and probably just use an anchor tag. I am approving the research but think this one should be raised to know whether this should be simply a definition proposal and not necessarily a full proposal due to its limited utilization across component libraries.
|
@gregwhitworth is there anything else I need to do here or should this be merged? Thanks! |
|
@khmakoto can you file an issue regarding the below:
|
|
I'll merge after you link the issue to this PR |
|
@gregwhitworth For sure! I've opened issue #257 regarding that. |
|
Is it just me or are these images super tiny?
|
|
I don't know if this changes anything, but I at least found it interesting that two of the libraries provide a disabled link state, when that doesn't exist in HTML (or ARIA). |
Yes, +1 to this. Link text should just appear as inline text as anchors without an href are treated as text. I'll add that there are visual implications with having this concept as well. While a disabled button does not need to meet contrast, a link which appears disabled is just text which must meet (currently) WCAG 2.1 AA contrast requirements. |
|
@gregwhitworth, this looks like one that can now be closed without any additional effort being required from anyone. |
|
Closing this based on: #253 |
7 participants
This PR adds a research page under the
Analysissection for theLinkcomponent and adds/updates theconceptsfor the libraries that have such a component.