-
Notifications
You must be signed in to change notification settings - Fork 218
Closed
Labels
popoverThe Popover APIThe Popover API
Description
This has been discussed in #311, particularly around this comment. Given the new approach for popup, and the associated resolutions not to have a "live" open content attribute, we need to revisit this issue. The questions:
- Should there be a CSS pseudo class that indicates when the popup is "open"?
- What should "open" mean here - in the top layer? Visible at all?
- What should the pseudo-class be called?
- Should this pseudo class apply to other top layer elements, like modal
<dialog>and fullscreen elements?
In my view:
- We should have a CSS pseudo class, to allow developers to style "open" vs. "closed" popups differently, and allow animations between these states. Note visibility: hidden vs. other choices mfreed7/popup#3, which is relevant here, since I believe a conclusion we're coming to is that both states (open and closed) should be developer-stylable. The only difference really being whether the popup is in the top layer.
- Given the above, I think the pseudo class should simply indicate top layer status. Visibility is controlled by the developer, so this pseudo class shouldn't be concerned with visibility. It should just indicate whether the given element is in the top layer.
- And given that, I think the new class should be called
:toplayeror something similar, rather than:openwhich can be confusing for a popup that is "closed" but "visible" in the page. - For consistency, I think we should push for this pseudo class to apply to any element that currently resides in the top layer, no matter how it got there. So include modal
<dialog>and fullscreen elements.
Thoughts appreciated.
scottaoharayinonov
Metadata
Metadata
Assignees
Labels
popoverThe Popover APIThe Popover API