Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opentelemetry-php/contrib-auto-guzzle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.2.0
Choose a base ref
...
head repository: opentelemetry-php/contrib-auto-guzzle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.2.1
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jun 17, 2025

  1. fix guzzle promise handling (#393) 

    In certain circumstances (eg Curl handler and middlewares configured such that no additional promise chaining
occurs), our post transfer hook can receive an already-resolved Promise. Since it's already resolved, our
extra callbacks won't be applied in a timely fashion (they're instead added to a queue and will be processed
as part of a shutdown handler, if not triggered by something earlier).
The upshot of this is a lot of memory being held on to for each request, and it seems that the default config
when we use guzzle as our SDK exporter will trigger this. The spans for export are non-recording, so nothing
user-visible happens, but the non-recording spans and promise callbacks are held in memory, seemingly forever
or until shutdown.
The fix for this is to check is the promise is already resolved, and if so force our extra promise to resolve.
    @brettmc
    brettmc authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    dd67e8a View commit details
    Browse the repository at this point in the history
Loading