Merged
Conversation
Resolved an issue with the intersect dialog (divided faces were not getting properly written the drawing_interface and were not getting added as OS model surface objects). Also improved the surface matching algorithm. New method uses centroid of the polygon for matching instead of trying to match every single vertex. Testing has been successful thus far, but it could benefit from additional testing.
Added beta testing option for intersections and surface matching.
Added beta testing options for intersect and surface matching.
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
I have read the CLA Document and I hereby sign the CLA |
…tudio-sketchup-plugin into skimoo_develop
Collaborator
Author
|
@Ski90Moo I have merged your code and published a RC1 for a 1.6.0 version at https://github.com/openstudiocoalition/openstudio-sketchup-plugin/releases/tag/v1.6.0-rc.1 Can you test it out and see if it is still working as intended? We'll include your name and affiliation in the release notes, let me know how you want to be listed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update and merge #113