Merged
Conversation
macumber
approved these changes
Sep 16, 2024
Collaborator
macumber
left a comment
macumber
left a comment
There was a problem hiding this comment.
Looks good, my only question is if we should drop 20.04? I’ll leave that up to you
Collaborator
Author
|
I was on 20.04 until last week, so my guess is that it's premature. We'll be forced to do it at some point when GHA removes the runner, but until then (and assuming E+ and OpenStudio both continue to do so), I think it's better to leave it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.