Skip to content

Fix #739 - Issues with Ubuntu 24.04: unmet apt dependencies, icon not showing#740

Merged
jmarrec merged 2 commits intodevelopfrom
739_Ubuntu2404
Sep 4, 2024
Merged

Fix #739 - Issues with Ubuntu 24.04: unmet apt dependencies, icon not showing#740
jmarrec merged 2 commits intodevelopfrom
739_Ubuntu2404

Conversation

@jmarrec
Copy link
Copy Markdown
Collaborator

@jmarrec jmarrec commented Sep 4, 2024

@jmarrec jmarrec self-assigned this Sep 4, 2024
@jmarrec
Copy link
Copy Markdown
Collaborator Author

jmarrec commented Sep 4, 2024 •
edited
Loading

@manuvarkey If you can spare the time, I'd really appreciate it if you could please test the installer from this PR on your Ubuntu 24.04 machine! (I don't have a 24.04 VM to test this on, and I'd rather not create one since I plan on upgrading to 24.04 for my machine soonish anyways). Thanks!

You should be able to download it from https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/10697681641?pr=740, direct link https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/10697681641/artifacts/1889902113

jmarrec
jmarrec commented Sep 4, 2024
View reviewed changes
CMakeLists.txt

# Focal Fossa (20.04) uses libwxgtk3.0-gtk3-0v5, apparently need libxcb-xinerama0 as well
set(CPACK_DEBIAN_PACKAGE_DEPENDS "libxcb-xinerama0 (>= 1.13), libwxgtk3.0-0v5 (>= 3.0.0) | libwxgtk3.0-0 (>=3.0.0) | libwxgtk3.0-gtk3-0v5 (>=3.0.0), libxcb-cursor0")
set(CPACK_DEBIAN_PACKAGE_DEPENDS "libxcb-xinerama0 (>= 1.13), libwxgtk3.0-0v5 (>= 3.0.0) | libwxgtk3.0-0 (>=3.0.0) | libwxgtk3.0-gtk3-0v5 (>=3.0.0) | libwxgtk3.2-1t64 (>= 3.2.0), libxcb-cursor0")
Copy link
Copy Markdown
Collaborator Author

@jmarrec jmarrec Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add dep alternative for libwxgtk3 for 24.04

debian/openstudioapp.desktop
Categories=Utility;X-OpenStudio;X-EnergyModeling;
MimeType=application/x-openstudio;

StartupWMClass=OpenStudioApp
Copy link
Copy Markdown
Collaborator Author

@jmarrec jmarrec Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's what's missing for 24.04, but not sure.

I tested that it still works on 20.04 with it though

Copy link
Copy Markdown
Collaborator Author

@jmarrec jmarrec Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://askubuntu.com/questions/1516383/missing-icons-in-dock-after-upgrade-to-ubuntu-24-04

Copy link
Copy Markdown
Collaborator Author

@jmarrec jmarrec Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

xprop WM_CLASS

@jmarrec
Copy link
Copy Markdown
Collaborator Author

jmarrec commented Sep 4, 2024

Alright, I kinda want to move fast, so I created a 24.04 Clean VM for testing.

It does install correctly now.

I see the icon properly when searching for it

image

And I do find the icon also on the left dock

image

@jmarrec jmarrec merged commit 2277fd5 into develop Sep 4, 2024
@jmarrec jmarrec deleted the 739_Ubuntu2404 branch September 4, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@jmarrec
Copy link
Copy Markdown
Collaborator Author

jmarrec commented Sep 4, 2024

@manuvarkey I tested this already! thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jmarrec jmarrec

Labels

component - Installer/Platform 📦 Enhancement Request New feature or request Platform - Ubuntu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v1.8.0-rc2] Issues with Ubuntu 24.04: unmet apt dependencies, icon not showing.

1 participant

@jmarrec