Conversation
jmarrec
commented
Mar 26, 2024
Comment on lines
+521
to
+525
| { | ||
| auto* content = new QLabel(m_modelerDescription); | ||
| mainLayout->addWidget(content); | ||
| content->setWordWrap(true); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Alternative (#include <QTextEdit> needed atop)
Suggested change
| { | |
| auto* content = new QLabel(m_modelerDescription); | |
| mainLayout->addWidget(content); | |
| content->setWordWrap(true); | |
| } | |
| { | |
| auto* content = new QTextEdit(m_modelerDescription); | |
| content->setStyleSheet("background: #E6E6E6;"); | |
| content->setFixedHeight(70); | |
| content->setAcceptRichText(false); | |
| content->setVerticalScrollBarPolicy(Qt::ScrollBarAsNeeded); | |
| content->setTabChangesFocus(true); | |
| content->setReadOnly(true); | |
| mainLayout->addWidget(content); | |
| } |
Collaborator
There was a problem hiding this comment.
I think we'd need scroll bars here, either for each section like this or one scroll bar for the whole preview.
Collaborator
Author
There was a problem hiding this comment.
the whole preview is scrollable already.
macumber
reviewed
Mar 26, 2024
| label = new QLabel(m_error->c_str()); | ||
| mainLayout->addWidget(label); | ||
|
|
||
| // TODO: why this empty label? |
Collaborator
There was a problem hiding this comment.
My guess is it was for spacing? Probably ok to remove as long as it still looks ok
macumber
reviewed
Mar 26, 2024
macumber
reviewed
Mar 26, 2024
Collaborator
|
Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.