Conversation
| collapsibleItem->setExpanded(false); | ||
| } | ||
| //collapsibleItem->itemList()->clearSelection(); | ||
| collapsibleItem->itemList()->clearSelection(); |
There was a problem hiding this comment.
What about the one below in onItemSelected, does that need uncommenting too?
There was a problem hiding this comment.
That's a good question. I have not found an instance where it causes an issue. In the library tabs the items aren't selectable so it doesn't matter if the individual items are selected or not. For the item lists in the materials tab, the first item is reselected when the category item is expanded anyway. So deselecting the hidden items seems like a waste of time. However, I got bit by being too aggressive earlier so I would be happy to put it back. I plan to ask the reporter of the bug to test an installer to see if they can find anything else.
…y when it is clicked again it will re-emit the itemSelected signal to re-draw the inspector in the loads (and possibly other) tabs
| m_targetTemperatureScheduleDZ = new OSDropZone(m_targetTemperatureScheduleVC); | ||
| m_targetTemperatureScheduleDZ->setMinItems(0); | ||
| m_targetTemperatureScheduleDZ->setMaxItems(1); | ||
| m_targetTemperatureScheduleDZ->setItemsAcceptDrops(true); |
There was a problem hiding this comment.
Configure all the drop zones to accept item drops. Fixes @Ski90Moo 's comment at #683 (comment)
Demo:
|
@macumber I added a change to fix something just reported, if you're ok with it, merge away please |
2 participants
Need to clearSelection for collapsibleItem when not expanded, that way when it is clicked again it will re-emit the itemSelected signal to re-draw the inspector in the loads, construction, and materials tabs. Fixes #683.