Merged
Conversation
Collaborator
|
Looks good to me, you want to update the binaries on the RC2 page? Or delete and re-tag RC2 to trigger the Windows signing? |
macumber
approved these changes
Jan 22, 2024
Collaborator
|
The Chromium web debugging was working for me on Windows without this, maybe I had dev dependencies or something else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RPATH broken for OpenStudioApplication 1.7.0-rc2 on Ubuntu #673
Fix OpenStudioApplication 1.7.0-rc2: cannot load qtwebengine (geometry preview / results tabs) #674
Fix Chromium debug fails #675
Ref v1.7.0-rc2 Testing: Call for help from the community #669