Skip to content

Additional output to run tab#496

Closed
macumber wants to merge 10 commits intodevelopfrom
110_workflow_stdout
Closed

Additional output to run tab#496
macumber wants to merge 10 commits intodevelopfrom
110_workflow_stdout

Conversation

@macumber
Copy link
Copy Markdown
Collaborator

@macumber macumber commented Mar 22, 2022 •
edited
Loading

Add additional arguments to the run command, needs OS 3.4.0.

We should consider removing the socket and just use QProcess::readyReadStandardOutput(), might remove need for #484

Fixes #110
Fixes #437

@macumber
Add additional arguments to the run command, needs OS 3.4.0. We shoul…
62faf7b 
…d consider removing the socket and just use stdout
@macumber macumber self-assigned this Mar 22, 2022
@macumber macumber added this to the OpenStudio Application 1.4.0 milestone Mar 22, 2022
@jmarrec
Copy link
Copy Markdown
Collaborator

jmarrec commented May 1, 2022

I resolved the merge conflicts, will let CI run and give it a test then merge.

@jmarrec jmarrec self-requested a review May 1, 2022 19:31
@jmarrec jmarrec mentioned this pull request May 2, 2022
Merged
@jmarrec
Copy link
Copy Markdown
Collaborator

jmarrec commented May 2, 2022 •
edited
Loading

I tried the installer from 9ccc0b7. The simulation did not run and the OSApp looked "just fine" when really the CLI, which is 3.3.0 on this one and does not yet have these new --show-stdout and co flags, was failing.

I think we should really check exit code / exit status on

OpenStudioApplication/src/openstudio_lib/RunTabView.cpp

Lines 181 to 197 in b286ab8

void RunView::onRunProcessFinished(int exitCode, QProcess::ExitStatus status) {
LOG(Debug, "run finished");
m_playButton->setChecked(false);
m_state = State::stopped;
m_progressBar->setMaximum(State::complete);
m_progressBar->setValue(State::complete);
std::shared_ptr<OSDocument> osdocument = OSAppBase::instance()->currentDocument();
osdocument->save();
osdocument->enableTabsAfterRun();
m_openSimDirButton->setEnabled(true);
if (m_runSocket) {
delete m_runSocket;
}
m_runSocket = nullptr;
}

496_failed

@jmarrec
Copy link
Copy Markdown
Collaborator

jmarrec commented May 2, 2022

You can't pass both --socket and --show-stdout. --show-stdout which I added in 3.4.0 is simply opening a socket to retrieve the data from openstudio-workflow-hem, which is exactly what we're already doing here already.

@jmarrec jmarrec force-pushed the 110_workflow_stdout branch from 63fcb32 to 8181ad8 Compare May 2, 2022 11:51
@jmarrec jmarrec force-pushed the 110_workflow_stdout branch from 5858565 to 22a0a3d Compare May 2, 2022 11:56
jmarrec added 2 commits May 2, 2022 17:28
@jmarrec
Implement a fallback when socket can't be opened: still display and s…
af2435a 
…tyle everything, but won't be using it as default since the E+ status updates aren't live (missing a flush in os CLI / workflow gem probably)
@jmarrec
Connect QProcess::errorOccurred to catch bad things happening like E+…
175e8a0 
… crashing
@jmarrec jmarrec self-assigned this May 2, 2022
@jmarrec
Copy link
Copy Markdown
Collaborator

jmarrec commented May 2, 2022

I revamped the PR:

Uploading Verbose_simulation_output.gif…

@jmarrec jmarrec closed this May 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
@macumber
Copy link
Copy Markdown
Collaborator Author

macumber commented May 3, 2022

It looks like you moved this to #513, is that right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmarrec jmarrec Awaiting requested review from jmarrec

Assignees

@macumber macumber

@jmarrec jmarrec

Labels

None yet

Projects

None yet

Milestone

OpenStudio Application 1.4.0

Development

Successfully merging this pull request may close these issues.

No error message for failed simulation with empty spaces Hard to see errors generated in ModelToIdf job in App

2 participants

@macumber @jmarrec