Update policies for OTC changes#146
Conversation
Update other policies as necessary to reflect the bylaws changes that introduced the OTC concept.
mspncp
left a comment
mspncp
left a comment
There was a problem hiding this comment.
LGTM, except for one change.
policies/committers.html
Outdated
|
|
||
| <p>To become a committer, start by contributing code. Read our | ||
| <p>To become a committer, start by contributing code (GitHub pull requests). | ||
| Read our |
There was a problem hiding this comment.
I don't think think that this addition is useful, it just distracts from the clear and concise statement of the sentence. (IOW I would revert the change.)
A useful description of how the code is contributed would require a lot more words, but that is outside the scope of this policy document. And just adding a laconic "(GitHub pull requests)" does not really explain anything.
There was a problem hiding this comment.
I reverted this change since it is entirely tangential to the main point of the PR anyway.
| </li> | ||
| <li> | ||
| <a href="omc-bylaws.html">OMC (project) Bylaws</a> | ||
| <a href="omc-bylaws.html">OpenSSL Bylaws</a> |
There was a problem hiding this comment.
Maybe rename the file to openssl-bylaws.html ?
There was a problem hiding this comment.
While I have no objection in principle to this, it turns out to be non-trivial since this page is referenced by quite a few other pages - so I'd rather keep it as-is for now.
There was a problem hiding this comment.
You can always use the new name, and have your webmaster set up a redirect in .httaccess for the old name.
|
I pushed a fixup addressing the comment above. |
|
Hmm, why is @mspncp's approval not visible? Github, what are you up to? |
It's there, but the check mark is greyed, because I'm only a committer and this is the web repository ;-) |
|
(It's only listed in the top right of the page, not beneath "Changes approved") |
|
Worx as designed ;-) |
Doh! Of course |
|
Should we vote on this? |
mspncp
left a comment
mspncp
left a comment
There was a problem hiding this comment.
Reapproved, this time for real. Hope this does not create a logical circle :-P
Since it is a consequence of the bylaw changes which were voted on by the OMC, it might be sufficient if you just add your own approval, then this pr will have four OMC approvals? Just and idea. |
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
I don't think a vote is required. These aren't by laws changes.
IMO, this does require a vote |
For future votes, it is possible to link to the "Changes" view up to a given commit in a given PR: https://github.com/openssl/web/pull/146/files/f43235924ab058f9559382efbeb4454508b5bc26 |
|
A vote is require to change policies. Always has been.
All official decisions are on the basis of a vote.
Tim.
…On Sat, 28 Dec. 2019, 7:29 am Nicola Tuveri, ***@***.***> wrote:
I started a vote on this:
Update various project policies to the text shown here:
#146 <#146> (as of commit f432359
<f432359>
)
For future votes, it is possible to link to the "Changes" view up to a
given commit in a given PR:
https://github.com/openssl/web/pull/146/files/f43235924ab058f9559382efbeb4454508b5bc26
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#146?email_source=notifications&email_token=ABYQ6QJZCSUNRPL5QHA3JCDQ2ZCPTA5CNFSM4J3ILBT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHXSS3Y#issuecomment-569321839>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYQ6QLCFKVJZTP3OQ2YR6DQ2ZCPTANCNFSM4J3ILBTQ>
.
|
|
While the vote is under way, we have a few issues that could use some OMC If anyone can spare some time: |
|
Note the vote to approve this change has passed. It is just awaiting merging. |
Update other policies as necessary to reflect the bylaws changes that introduced the OTC concept. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matthias St. Pierre <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #146)
|
Pushed!! |
After the changes in openssl/web#146 `gitaddrev` (on which `addrev` depends) required an update to count OTC approvals rather than OMC approvals.
After the changes in openssl/web#146 `gitaddrev` (on which `addrev` depends) required an update to count OTC approvals rather than OMC approvals. Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #50)
8 participants
Update other policies as necessary to reflect the bylaws changes that
introduced the OTC concept.