Conversation
After the changes in openssl/web#146 `gitaddrev` (on which `addrev` depends) required an update to count OTC approvals rather than OMC approvals.
|
My edit: typo |
levitte
left a comment
There was a problem hiding this comment.
Looks good to me. I haven't tested, but I see no reason why this should not work.
|
Side note: -fu, not -foo. https://en.wiktionary.org/wiki/-fu |
|
How does this impact the review headers for other repos? So, with addrev you can specify --web or --tools to specify that you are applying headers for a different repo than the main code one. For that matter what are the review rules for other repos. For the code repo it is clear. But what about web and tools? It kind of makes sense at least for tools to be OTC owned? |
I believe OMC should clearly state this officially somewhere to clear the ambiguity: personally I would say that
That's of course just my personal opinion, and I only use a tiny fraction of the tools in That being said, until your comment I did not even think that Anyway, until the OMC states otherwise, this PR must be merged by an OMC member. |
slontis
left a comment
There was a problem hiding this comment.
I did similiar changes before I noticed your PR.
I left the [OMC] tag in so that it printed both [OMC] [OTC] in the --list part.
Its the same otherwise..
|
@mattcaswell didn't we discuss some of the ownership at the F2F? I've a recollection that at least one of the repos looked like it should be jointly owned (i.e. needed splitting). |
mattcaswell
left a comment
There was a problem hiding this comment.
I don't want the wider issues brought up here stopping progress on reviews. So approving this for now.
After the changes in openssl/web#146 `gitaddrev` (on which `addrev` depends) required an update to count OTC approvals rather than OMC approvals. Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #50)
|
Pushed. |
After the changes in openssl/web#146
gitaddrev(on whichaddrevdepends) required an update to count OTCapprovals rather than OMC approvals.