run-checker: Check enabling and disabling trace#37
Closed
levitte wants to merge 2 commits intoopenssl:masterfrom
Closed
run-checker: Check enabling and disabling trace#37levitte wants to merge 2 commits intoopenssl:masterfrom
levitte wants to merge 2 commits intoopenssl:masterfrom
Conversation
InfoHunter
approved these changes
Mar 14, 2019
mspncp
reviewed
Mar 14, 2019
Contributor
mspncp
left a comment
mspncp
left a comment
There was a problem hiding this comment.
Why both? For all other options, only the non-default is specified.
Member
|
What is the default behaviour of trace? |
Contributor
|
It’s currently changing from enabled to disabled, see #8474. |
Member
Author
|
It's precisely because we're currently in a state of fluctuation that I made it both. (side note: when linking to pull requests in a different repo, you have to be a little more verbose: openssl/openssl#8474) |
Contributor
|
Thanks, I know. But I was doing it on my mobile (once again), so I was too lazy :P |
Contributor
Since openssl/openssl#8474 has been merged meanwhile, I'd prefer having only the non-default now. |
Member
Author
|
Sure |
mattcaswell
approved these changes
Mar 15, 2019
t-j-h
approved these changes
May 13, 2019
levitte
added a commit
that referenced
this pull request
May 13, 2019
Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tim Hudson <[email protected]> (Merged from #37)
Member
Author
|
Merged. 31b2767 run-checker: Check enabling and disabling trace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.