Skip to content

coding-style.md: add various rules on names#48

Closed
DDvO wants to merge 6 commits intoopenssl:masterfrom
DDvO:coding-style-names
Closed

coding-style.md: add various rules on names#48
DDvO wants to merge 6 commits intoopenssl:masterfrom
DDvO:coding-style-names

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented May 4, 2022

Add a 3rd chunk of rules, taken from the list of proposed ones collected at openssl/openssl#10725,
focusing on names.

On this occasion clean up redundancy in the Naming chapter and re-order the rules.

levitte
levitte reviewed May 4, 2022
View reviewed changes
levitte
levitte reviewed May 4, 2022
View reviewed changes
@DDvO DDvO force-pushed the coding-style-names branch from ccbca15 to b44dcdf Compare May 5, 2022 07:38
@DDvO DDvO force-pushed the coding-style-names branch from b44dcdf to debb1b1 Compare May 5, 2022 07:50
t8m
t8m requested changes May 5, 2022
View reviewed changes
@t8m t8m added the policy change A change to a policy is being proposed label May 5, 2022
@DDvO DDvO requested review from levitte and t8m May 6, 2022 10:49
@DDvO DDvO mentioned this pull request May 9, 2022
Closed
@DDvO
Copy link
Contributor Author

DDvO commented May 9, 2022

@levitte are your above points sufficiently addressed, so can you approve?

@t8m t8m added the discussed The issue/pr was discussed by the OTC label May 10, 2022
slontis
slontis reviewed May 17, 2022
View reviewed changes
slontis
slontis reviewed May 17, 2022
View reviewed changes
slontis
slontis reviewed May 17, 2022
View reviewed changes
@t8m
Copy link
Member

t8m commented May 18, 2022

@DDvO Would you like to address (at least some) @slontis comments?

@DDvO
Copy link
Contributor Author

DDvO commented May 19, 2022 •
edited
Loading

@DDvO Would you like to address (at least some) @slontis comments?

Sure - I've just been too busy to get back to it, but done now.

@t8m
Copy link
Member

t8m commented May 25, 2022

Starting the vote for coding-style.md: add various rules on names at commit 5a3b1ac

@t8m t8m added the ready to vote The policy change proposal is ready to be voted on by the OTC label May 25, 2022
@t8m
Copy link
Member

t8m commented May 25, 2022

Vote: [+1]

1 similar comment
@mattcaswell
Copy link
Member

mattcaswell commented May 25, 2022

Vote: [+1]

@romen
Copy link
Member

romen commented May 25, 2022

Vote: [+0]

@beldmit
Copy link
Member

beldmit commented May 25, 2022

Vote: [+1]

3 similar comments
@slontis
Copy link
Member

slontis commented May 25, 2022

Vote: [+1]

@t-j-h
Copy link
Member

t-j-h commented May 25, 2022

Vote: [+1]

@paulidale
Copy link
Contributor

paulidale commented May 26, 2022

Vote: [+1]

@kroeckx
Copy link
Member

kroeckx commented May 30, 2022

Voting +1

@levitte
Copy link
Member

levitte commented May 31, 2022

Vote: [+1]

@t8m
Copy link
Member

t8m commented May 31, 2022

@mspncp ping for vote

@mspncp
Copy link
Contributor

mspncp commented May 31, 2022

Vote: [+1]

@t8m
Copy link
Member

t8m commented Jun 2, 2022

Closing the vote.

Topic: coding-style.md: add various rules on names at commit 5a3b1ac
       This will become an official OTC policy.
Proposed by: Tomas
Issue link: https://github.com/openssl/technical-policies/pull/48
Public: yes
Opened: 2022-05-25
Closed: 2022-06-02
Accepted: yes   (for: 9, against: 0, abstained: 1, not voted: 0)

   Dmitry     [+1]
   Matt       [+1]
   Pauli      [+1]
   Tim        [+1]
   Richard    [+1]
   Shane      [+1]
   Tomas      [+1]
   Kurt       [+1]
   Matthias   [+1]
   Nicola     [+0]

@t8m t8m closed this Jun 2, 2022
@t8m t8m added accepted The policy change proposal was accepted by an OTC vote and removed ready to vote The policy change proposal is ready to be voted on by the OTC labels Jun 2, 2022
@DDvO DDvO mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@levitte levitte Awaiting requested review from levitte

+1 more reviewer

@slontis slontis slontis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accepted The policy change proposal was accepted by an OTC vote discussed The issue/pr was discussed by the OTC policy change A change to a policy is being proposed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.