coding-style.md: add various rules on spaces, lines, and comments#47
Closed
DDvO wants to merge 4 commits intoopenssl:masterfrom
Closed
coding-style.md: add various rules on spaces, lines, and comments#47DDvO wants to merge 4 commits intoopenssl:masterfrom
DDvO wants to merge 4 commits intoopenssl:masterfrom
Conversation
levitte
reviewed
May 4, 2022
paulidale
reviewed
May 5, 2022
paulidale
approved these changes
May 5, 2022
mattcaswell
reviewed
May 5, 2022
t8m
reviewed
May 5, 2022
t8m
approved these changes
May 5, 2022
mattcaswell
approved these changes
May 9, 2022
t8m
reviewed
May 10, 2022
Member
|
Looks ok to me. |
t8m
added
the
ready to vote
Member
|
Starting the vote for coding-style.md: add various rules on spaces, lines, and comments at commit fcecd20 |
Member
|
Vote: [+1] |
Member
|
Vote [+1] |
1 similar comment
Member
|
Vote [+1] |
Member
|
Vote: [+1] |
2 similar comments
Contributor
|
Vote: [+1] |
Member
|
Vote: [+1] |
Member
|
Vote: [+0] |
Member
|
@levitte @paulidale @kroeckx last call for votes 😁 |
Member
|
Ah, not @paulidale but @mspncp |
Contributor
|
Vote: [+0] |
kroeckx
reviewed
May 30, 2022
|
|
||
| Place comments above or to the right of the code they refer to. | ||
| Comments referring to the code line after | ||
| should be indented equally to that code line. |
Member
There was a problem hiding this comment.
Do we need to clarify this more of where you expect to find the comment in case of an if / else? Do you write the comment before the if, or inside the if?
Member
There was a problem hiding this comment.
I would say that it depends on the comment itself. Does it explain the body, or does it explain why there's a condition?
Member
|
Voting +1 |
Member
|
Vote: [+1] |
Member
|
Vote is now closed as accepted. |
t8m
added
accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a 2nd chunk of rules, taken from the list of proposed ones collected at openssl/openssl#10725,
focusing on whitespace.