Fix bugs in "info" commands flags#9986
Fix bugs in "info" commands flags#9986richsalz wants to merge 1 commit intoopenssl:masterfrom richsalz:remove-info-aliases
Conversation
Remove -c/-e/-m aliases, OpenSSL commands don't do that. Fix typo's in the documentation. Fix -module flag to print the right thing.
|
This is a new command for 3.0, so no compatibility issues. |
|
(I kinda wish this and version were one command.) |
Er, so?
Yeah well. Quite a lot of the info has nothing to do with versions per se, and |
|
Consistency is important. You should either have just short commands, like version, or have just long commands. I prefer just short commands. Shall I change this? |
|
I disagree with you regarding this design choice (not bug), but if I must choose only one, then I'll go for the long options. There's a reason I didn't assign short options to everything, I ran out of reasonable letter that weren't already taken. Besides, almost all our sub-commands (I think only |
|
Well, we can't change the existing programs and I think adding aliases is going to cause problems. And tsget was never a model of good OpenSSL integration :) I am sorry if I insulted you by saying "bug" I hope it helps that lines 2 and 3 of the commit pointed out real bugs. |
levitte
left a comment
There was a problem hiding this comment.
Feeling satisfied the air is cleared 😉
|
This is ready, can it get merged soon? I will have to retrofit these changes into #9953. |
Remove -c/-e/-m aliases, OpenSSL commands don't do that. Fix typo's in the documentation. Fix -module flag to print the right thing. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #9986)
|
Done 0773687 Fix bugs in "info" commands flags |
|
Oh damn... as I hit submit, I noticed Travis had a red cross. Eh well |
|
I'll fix any issues ASAP within an hour or two if you don't beat me too it. I am hoping "Travis failures are unrelated" to coin a phrase :) |
|
False alarm, it was just a timeout: https://travis-ci.org/openssl/openssl/jobs/588543043 |
Remove -c/-e/-m aliases, OpenSSL commands don't do that.
Fix typo's in the documentation.
Fix -module flag to print the right thing.