Fix reversed meaning of error codes#9529
Closed
mukrop wants to merge 1 commit intoopenssl:masterfrom
mukrop:master
Closed
Fix reversed meaning of error codes#9529mukrop wants to merge 1 commit intoopenssl:masterfrom mukrop:master
mukrop wants to merge 1 commit intoopenssl:masterfrom
mukrop:master
Conversation
The meaning of the X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY and X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT error codes were still reversed in the X509_STORE_CTX_get_error function documentation. This used to be the problem also in the verify application documentation, but was fixed on 2010-02-23 in 7d3d178.
openssl-machine
added
the
hold: cla required
Contributor
|
@mukrop it's great that you're still involved and going to help fix doc problems! |
Contributor
Author
|
I got acknowledgment that my CLA was received. I'm not sure now -- will the CLA check run again automatically? |
Member
|
Close/reopen to kick CLA bot |
openssl-machine
removed
the
hold: cla required
mattcaswell
added
branch: 1.1.1
mattcaswell
approved these changes
Aug 6, 2019
mattcaswell
added
the
approval: review pending
slontis
approved these changes
Aug 7, 2019
slontis
added
approval: done
levitte
pushed a commit
that referenced
this pull request
Aug 8, 2019
The meaning of the X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY and X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT error codes were still reversed in the X509_STORE_CTX_get_error function documentation. This used to be the problem also in the verify application documentation, but was fixed on 2010-02-23 in 7d3d178. Reviewed-by: Shane Lontis <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #9529) (cherry picked from commit 6d5aa88)
Member
|
Pushed to master and 1.1.1. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Aug 8, 2019
The meaning of the X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY and X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT error codes were still reversed in the X509_STORE_CTX_get_error function documentation. This used to be the problem also in the verify application documentation, but was fixed on 2010-02-23 in 7d3d178. Reviewed-by: Shane Lontis <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #9529)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meaning of the X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY and X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT error codes were still reversed in the X509_STORE_CTX_get_error function documentation.
This used to be the problem also in the verify application documentation, but was fixed on 2010-02-23 in 7d3d178.
Although the change may be trivial, I'll send the ICLA as I expect to be doing multiple such smaller documentation-related pull requests in the near future.
@richsalz: This is a bit from newer research on the usability of X509-capable libraries here at CRoCS, Masaryk University, you reviewed my previous suggestion in #4548.