GCM cipher in provider now fails if passed bad keylength#9512
GCM cipher in provider now fails if passed bad keylength#9512slontis wants to merge 2 commits intoopenssl:masterfrom
Conversation
|
ping |
levitte
left a comment
levitte
left a comment
There was a problem hiding this comment.
This is a solution for sure, but not a tenable solution for the future, as the implication is that every implementation will have to check for every parameter thrown their way that they think affects other implementations of their kind. With 3rd party providers in the mix, it will be an impossible task.
So I see this as an interim solution until we've resolved the discussion going on in #9510, and to be acceptable, it should be marked with /* TODO(3.0) ...*/ comments explaining this.
Updated with a TODO. |
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
As a temporary solution this is ok. Definitely not a long term solution though.
Fixes #9500 Reviewed-by: Matt Caswell <[email protected]> (Merged from #9512)
|
This has been merged to master. Thanks.. |
3 participants
Fixes #9500
Checklist