Temporary workaround for ectest.c for [extended tests]#9474
Closed
romen wants to merge 1 commit intoopenssl:masterfrom
Closed
Temporary workaround for ectest.c for [extended tests]#9474romen wants to merge 1 commit intoopenssl:masterfrom
romen wants to merge 1 commit intoopenssl:masterfrom
Conversation
[extended tests] This is a temporary workaround for issue openssl#9251, which contains a full discussion of the real problem. As a temporary workaround, we test `EC_GROUP_new_from_ecparameters()` against a curve that does not currently have alternative implementations. The proper fix is dependant on resolution of issue openssl#8615
mattcaswell
approved these changes
Jul 28, 2019
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Ooops...I meant to hit "approve"
This was referenced Jul 28, 2019
Member
Author
|
I will wait for @slontis because originally he wanted to open this, but apparently changed his mind at some point, so maybe he has some feedback to give. |
Member
Author
|
Failed travis is probably due to #8968 |
Member
slontis
approved these changes
Jul 28, 2019
Member
slontis
left a comment
slontis
left a comment
There was a problem hiding this comment.
I decided not to fix this before, so that the issue might become more visible.
Member
Author
|
Merged as f5b7f99 |
levitte
pushed a commit
that referenced
this pull request
Jul 31, 2019
[extended tests] This is a temporary workaround for issue #9251, which contains a full discussion of the real problem. As a temporary workaround, we test `EC_GROUP_new_from_ecparameters()` against a curve that does not currently have alternative implementations. The proper fix is dependant on resolution of issue #8615 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Shane Lontis <[email protected]> (Merged from #9474)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[extended tests]
This is a temporary workaround for issue #9251, which contains a full
discussion of the real problem.
As a temporary workaround, we test
EC_GROUP_new_from_ecparameters()against a curve that does not currently have alternative
implementations.
The proper fix is dependant on resolution of issue #8615