Deprecate the public definition of ERR_STATE#9462
Deprecate the public definition of ERR_STATE#9462levitte wants to merge 3 commits intoopenssl:masterfrom
Conversation
|
This is a step toward #9082, which is marked to happen in 4.0 |
include/openssl/err.h
Outdated
There was a problem hiding this comment.
I don't understand why you make a new public file to deprecated something. Why don't you just put the #if around it, instead of moving it to a new file?
There was a problem hiding this comment.
Because crypto/err/err.c still needs the definition. The easiest was to place it in another file that is unguarded. Th other solution would be to duplicate the definition in a private header, but that would be a bad solution.
There was a problem hiding this comment.
Another solution is to have an internal macro defined by crypto/err/err.c, say OPENSSL_FORCEDEF_ERR_STATE, which overrides deprecation. Is that preferable?
There was a problem hiding this comment.
I was typing that in my browser when your reply showed up. :) FWIW, I think that's preferable.
There was a problem hiding this comment.
Okie. Maybe... Yesterday, I thought that was a bad idea, but I'm less sure today.
|
You also need to deprecate ERR_get_state |
Ah, right |
Done |
|
I had forgotten |
levitte
force-pushed
the
deprecate-err_state
branch
from
d243457 to
02621bd
Compare
mattcaswell
added
the
approval: done
levitte
force-pushed
the
deprecate-err_state
branch
from
4439fd3 to
4af440a
Compare
The intention is to make it opaque later on.
Internally, we still need this function, so we make it internal and then add a new ERR_get_state() that simply calls the internal variant, unless it's "removed" by configuration.
levitte
force-pushed
the
deprecate-err_state
branch
from
4af440a to
a98c3fa
Compare
|
Rebase meant a couple of small changes. Re-review, please? |
The intention is to make it opaque later on. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9462)
Internally, we still need this function, so we make it internal and then add a new ERR_get_state() that simply calls the internal variant, unless it's "removed" by configuration. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9462)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9462)
4 participants
The intention is to make it opaque later on.