Change DH parameters to generate the order q subgroup instead of 2q [1.1.1] #9435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids leaking bit 0 of the private key. Backport-of: openssl#9363
bernd-edlinger
added
the
branch: 1.1.1
bernd-edlinger
changed the title
kroeckx
reviewed
Jul 22, 2019
kroeckx
reviewed
Jul 22, 2019
kroeckx
approved these changes
Jul 24, 2019
kroeckx
added
the
approval: done
Member
Author
|
Merged to 1.1.1 as ddd16c2. Thanks! |
Member
|
This caused travis to start failing on the 1.1.1 branch. See issue #9792. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it was a (minor) bug-fix it seems appropriate to
backport #9363 to 1.1.1