Correct the Extended Master Secret string for EBCDIC#9430
Correct the Extended Master Secret string for EBCDIC#9430mattcaswell wants to merge 2 commits intoopenssl:masterfrom
Conversation
mattcaswell
added
branch: master
|
Is there any backwards compatibility issue with changing this? |
|
EBCDIC machines could talk to each other, but not to the rest of
the world.
|
|
Is there a reason we can't always use that string, even when CHARSET_EBCDIC is not defined, to avoid such problems in the future? |
|
So uhmmm, with this change, does that mean that un-updated EBCDIC machines will suddenly not be able to talk with updated EBCDIC machines? |
|
If this is the case then you need it to be configurable so they can get the old incorrect behaviour also |
Yes, that could be done
Yes - that is correct (if EMS is negotiated). Although with the current situation un-updated EBCDIC machines will not be able to talk to any non-EBCDIC machines.
We could introduce a define to get the old constant value...but I'm a little reluctant to do that since such things seem to hang around unused and as dead code for a long time. Could we get away with just a CHANGES entry? |
|
I'm not at all concerned about backward compatibility with previous versions. We should just fix it. |
|
A CHANGES entry would be advisable. I'll approve with that added |
mattcaswell
force-pushed
the
extms-ebcdic
branch
from
acdc612 to
25d04d5
Compare
|
I added a CHANGES entry. I expect there to be some trivial conflicts when I backport to 1.1.1 due to the CHANGES file...but nothing that seems to warrant a new PR. |
The macro TLS_MD_MASTER_SECRET_CONST is supposed to hold the ascii string "extended master secret". On EBCDIC machines it actually contained the value "extecded master secret"
mattcaswell
force-pushed
the
extms-ebcdic
branch
from
25d04d5 to
98e9f16
Compare
|
Rebased to resolve a conflict with master. Ping? |
paulidale
added
the
approval: done
|
Pushed. Thanks. |
The macro TLS_MD_MASTER_SECRET_CONST is supposed to hold the ascii string "extended master secret". On EBCDIC machines it actually contained the value "extecded master secret" Reviewed-by: Paul Dale <[email protected]> (Merged from #9430) (cherry picked from commit c1a3f16)
The macro TLS_MD_MASTER_SECRET_CONST is supposed to hold the ascii string "extended master secret". On EBCDIC machines it actually contained the value "extecded master secret" Reviewed-by: Paul Dale <[email protected]> (Merged from #9430)
5 participants
The macro TLS_MD_MASTER_SECRET_CONST is supposed to hold the ascii string
"extended master secret". On EBCDIC machines it actually contained the
value "extecded master secret"