mention what happens if OPENSSL_NO_RC2 is defined#9415
Closed
vladak wants to merge 1 commit intoopenssl:masterfrom
Closed
mention what happens if OPENSSL_NO_RC2 is defined#9415vladak wants to merge 1 commit intoopenssl:masterfrom
vladak wants to merge 1 commit intoopenssl:masterfrom
Conversation
openssl-machine
added
the
hold: cla required
vladak
force-pushed
the
pkcs12_app_man_rc2
branch
from
763c854 to
30b19f7
Compare
mattcaswell
added
branch: 1.1.1
mattcaswell
approved these changes
Jul 19, 2019
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Looks like we are still awaiting a CCLA update for you? Do you have an update on this?
mattcaswell
added
the
approval: review pending
Contributor
Author
|
Yep, let me ping the internal person. |
Member
|
Can I suggest we just always make 3DES the default. |
Member
In master, yes. In 1.1.1 we can't really do that so this PR would still be relevant there. |
Member
|
I can't believe that NID_pbe_WithSHA1And3_Key_TripleDES_CBC is still the best that pkcs#12 supports, and I wonder what happens if you use the -aes128 option. |
Contributor
Author
|
I forgot to say but this is intended for 1.1.1 in the end.
Dne pá 19. 7. 2019 16:33 uživatel mattcaswell <[email protected]>
napsal:
… Can I suggest we just always make 3DES the default.
In master, yes. In 1.1.1 we can't really do that so this PR would still be
relevant there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9415?email_source=notifications&email_token=AAWMMDEAFG5VHAHYGFMMYI3QAHGDFA5CNFSM4IFGJKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2LZWYY#issuecomment-513252195>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWMMDDJ72H5PWCJQGX2DRTQAHGDFANCNFSM4IFGJKFA>
.
|
Contributor
Author
|
closing to kick the CLA bot |
openssl-machine
removed
the
hold: cla required
Contributor
|
The internal person has somewhat disappeared but they managed to obtain a letter from an othorty Filter in Oracal Legal. The response added you to the Oracle CCLA. |
Contributor
Author
|
Seems like this was already cleared.
Dne čt 8. 8. 2019 13:33 uživatel Pauli <[email protected]> napsal:
… The internal person has somewhat disappeared but they managed to obtain a
letter from an othorty Filter in Oracal Legal. The response added you to
the Oracle CCLA.
It will take a day for this to be incorporated into the contributors
database.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#9415?email_source=notifications&email_token=AAWMMDERS5ME7TFOYVTTLELQDP77LA5CNFSM4IFGJKFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33KK5A#issuecomment-519480692>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWMMDFYVAZGIMHFOG34Q2DQDP77LANCNFSM4IFGJKFA>
.
|
mattcaswell
approved these changes
Aug 9, 2019
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Reconfirming this now CLA issues are resolved.
Still needs second review.
t8m
approved these changes
Aug 9, 2019
mattcaswell
added
approval: done
Member
|
Pushed to master and 1.1.1. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Aug 9, 2019
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #9415) (cherry picked from commit 8c47e55)
levitte
pushed a commit
that referenced
this pull request
Aug 9, 2019
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #9415)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in cset 7e1b748 modified the
pkcs12command to use 3DES for certificate encryption if RC2 is disabled. This updates the man page to reflect the change.