Rework EVP_MD support, enhance existing functions#9391
Closed
levitte wants to merge 5 commits intoopenssl:masterfrom
Closed
Rework EVP_MD support, enhance existing functions#9391levitte wants to merge 5 commits intoopenssl:masterfrom
levitte wants to merge 5 commits intoopenssl:masterfrom
Conversation
mattcaswell
requested changes
Jul 19, 2019
levitte
force-pushed
the
provider-digest-flags
branch
from
8768fa4 to
67cca34
Compare
Member
Author
|
Darn, it looks like my rework of the functions in |
levitte
force-pushed
the
provider-digest-flags
branch
from
1bc87d6 to
7baf16c
Compare
Member
Author
|
It turned out that I was wrong regarding -2 for unsupported control types. At least in the EVP API, -1 seems to be the return value for that. |
levitte
force-pushed
the
provider-digest-flags
branch
2 times, most recently
from
c720faf to
6844d68
Compare
Member
Author
|
Ping. Re-review needed |
A lot of the different numbers associated with digests are really algorithm parameters. block size, digest length, that sort of thing.
…faces Also clean up EVP_MD_CTX_ctrl(), which did use these interfaces, but development since allows for more elegant code.
The latter should only be ussed with legacy methods.
levitte
force-pushed
the
provider-digest-flags
branch
from
6844d68 to
13ee76d
Compare
Member
Author
|
Ping! |
mattcaswell
approved these changes
Aug 12, 2019
mattcaswell
added
the
approval: done
Member
Author
|
Merged. 2893111 Make more use of OSSL_PARAM for digests |
levitte
added a commit
that referenced
this pull request
Aug 12, 2019
A lot of the different numbers associated with digests are really algorithm parameters. block size, digest length, that sort of thing. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9391)
levitte
added a commit
that referenced
this pull request
Aug 12, 2019
…faces Also clean up EVP_MD_CTX_ctrl(), which did use these interfaces, but development since allows for more elegant code. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9391)
levitte
added a commit
that referenced
this pull request
Aug 12, 2019
…params Reviewed-by: Matt Caswell <[email protected]> (Merged from #9391)
levitte
added a commit
that referenced
this pull request
Aug 12, 2019
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9391)
levitte
added a commit
that referenced
this pull request
Aug 12, 2019
The latter should only be ussed with legacy methods. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9391)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds missing support for providers in diverse EVP_MD and EVP_MD_CTX functions, and does a bit of cleanup as well.
This is similar to #9328, but for EVP_MD