An utility API to get negotiated Key exchange alg group NID#9323
Closed
raja-ashok wants to merge 3 commits intoopenssl:masterfrom
Closed
An utility API to get negotiated Key exchange alg group NID#9323raja-ashok wants to merge 3 commits intoopenssl:masterfrom
raja-ashok wants to merge 3 commits intoopenssl:masterfrom
Conversation
paulidale
reviewed
Jul 8, 2019
slontis
reviewed
Jul 10, 2019
raja-ashok
force-pushed
the
master-negotitated-group
branch
from
8910b2e to
e09d2fc
Compare
raja-ashok
force-pushed
the
master-negotitated-group
branch
from
e09d2fc to
4760694
Compare
Contributor
Author
|
Requesting to review and provide comments for this new API. This kind of API is mainly needed on TLS v1.3 client. So that it can avoid 2 RTT handshake on subsequent connections to same server. |
mattcaswell
requested changes
Aug 5, 2019
raja-ashok
force-pushed
the
master-negotitated-group
branch
from
4760694 to
52584df
Compare
mattcaswell
approved these changes
Aug 6, 2019
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Approved subject to the minor language reword being done.
mattcaswell
added
the
approval: review pending
raja-ashok
force-pushed
the
master-negotitated-group
branch
from
52584df to
40353a9
Compare
mattcaswell
approved these changes
Aug 6, 2019
paulidale
approved these changes
Aug 6, 2019
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
Wording nits. With these fixed, it's all good.
raja-ashok
force-pushed
the
master-negotitated-group
branch
from
40353a9 to
24bb9c4
Compare
Member
|
Travis failure is unrelated. |
mattcaswell
added
approval: done
Member
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Aug 6, 2019
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #9323)
levitte
pushed a commit
that referenced
this pull request
Aug 6, 2019
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #9323)
levitte
pushed a commit
that referenced
this pull request
Aug 6, 2019
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #9323)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new utility API
SSL_get_negotiated_group()to get the negotiated key exchange algorithm on a TLSv1.3 connection. Currently there is an another APISSL_get_shared_group()which is supported only for server and it returns nth shared group.Checklist