Add Common shared code needed to move aes ciphers to providers#9301
Closed
slontis wants to merge 6 commits intoopenssl:masterfrom
Closed
Add Common shared code needed to move aes ciphers to providers#9301slontis wants to merge 6 commits intoopenssl:masterfrom
slontis wants to merge 6 commits intoopenssl:masterfrom
Conversation
Member
Author
This was referenced Jul 3, 2019
levitte
reviewed
Jul 3, 2019
mattcaswell
requested changes
Jul 3, 2019
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Travis failures look relevant.
This was referenced Jul 8, 2019
levitte
requested changes
Jul 9, 2019
Custom aes ciphers will be placed into multiple new files (instead of the monolithic setup used in the e_aes.c legacy code) so it makes sense to have a header for the platform specific code that needs to be shared between files. modes_lcl.h has also moved to modes_int.h to allow sharing with the provider source. Code that will be common to AEAD ciphers has also been added. These will be used by seperate PR's for GCM, CCM & OCB.
slontis
force-pushed
the
prov_aes_shared_changes
branch
from
309e193 to
355ff6e
Compare
Member
Author
levitte
requested changes
Jul 12, 2019
Member
mattcaswell
approved these changes
Jul 12, 2019
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
LGTM. Approved assuming the minor nit is fixed.
Member
Author
|
@levitte are you happy with these changes? |
levitte
requested changes
Jul 13, 2019
Member
levitte
left a comment
levitte
left a comment
There was a problem hiding this comment.
Not quite happy with how things are moving around
slontis
force-pushed
the
prov_aes_shared_changes
branch
from
29a21a7 to
bd476b3
Compare
slontis
force-pushed
the
prov_aes_shared_changes
branch
from
bd476b3 to
181087f
Compare
levitte
requested changes
Jul 15, 2019
Member
|
Speaking of our dispute over |
levitte
approved these changes
Jul 15, 2019
Member
Author
Until we can completely remove most of e_aes.c I dont know that it makes much difference.. |
slontis
added
branch: master
slontis
added a commit
to slontis/openssl
that referenced
this pull request
Jul 16, 2019
Custom aes ciphers will be placed into multiple new files (instead of the monolithic setup used in the e_aes.c legacy code) so it makes sense to have a header for the platform specific code that needs to be shared between files. modes_lcl.h has also moved to modes_int.h to allow sharing with the provider source. Code that will be common to AEAD ciphers has also been added. These will be used by seperate PR's for GCM, CCM & OCB. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from openssl#9301)
Member
|
The dangers of waiting too long to actually merge the PR... please do rebase |
Member
Author
|
It has been merged already. Forgot to close it.. Thanks |
Member
|
Ah! yeah that went unnoticed. I would like to encourage you to write something when you do merge. You do not have to do what I do (I dump a oneline log of all final commits), but something would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom aes ciphers will be placed into multiple new files
(instead of the monolithic setup used in the e_aes.c legacy code)
so it makes sense to have a header for the platform specific
code that needs to be shared between files.
modes_lcl.h has also moved to modes_int.h to allow sharing with the
provider source.
Code that will be common to AEAD ciphers has also been added. These
will be used by seperate PR's for GCM, CCM & OCB.
Checklist