Restrict usage of bio_dgram_sctp_data only to DGRAM SCTP methods#9216
Closed
raja-ashok wants to merge 1 commit intoopenssl:masterfrom
Closed
Restrict usage of bio_dgram_sctp_data only to DGRAM SCTP methods#9216raja-ashok wants to merge 1 commit intoopenssl:masterfrom
raja-ashok wants to merge 1 commit intoopenssl:masterfrom
Conversation
raja-ashok
force-pushed
the
master-dgram-sctp
branch
2 times, most recently
from
28b337b to
b3eb552
Compare
Contributor
Author
|
Requesting to review and provide comments on this change. |
mattcaswell
reviewed
Jul 30, 2019
raja-ashok
force-pushed
the
master-dgram-sctp
branch
from
b3eb552 to
7664279
Compare
raja-ashok
force-pushed
the
master-dgram-sctp
branch
from
7664279 to
a2f8a93
Compare
Contributor
Author
|
Now the changes are to make |
Contributor
Author
|
Or shall we call |
Member
I think we just leave it as it is for now. |
mattcaswell
approved these changes
Aug 5, 2019
mattcaswell
added
the
approval: review pending
Member
|
Needs second review. |
mattcaswell
added
approval: done
Member
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Aug 9, 2019
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #9216)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ptrmember ofBIOshould be dereferenced only on functions ofBIO_METHOD. But in DGRAM SCTP it is accessed outside. That means members ofbio_dgram_sctp_dataare accessed other thanBIO_METHODfunctions likeBIO_dgram_sctp_notification_cb,BIO_dgram_sctp_wait_for_dryandBIO_dgram_sctp_msg_waiting. I feel this should be avoided.So added new control command to set the members (
handle_notificationsandnotification_context) required to access outsideBIO_METHODfunctions. And also madeBIO_dgram_sctp_wait_for_dry()andBIO_dgram_sctp_msg_waiting()as part of control function.Checklist