Change ERR_add_error_[v]data to append#9181
Closed
richsalz wants to merge 3 commits intoopenssl:masterfrom
richsalz:vdata-append
Closed
Change ERR_add_error_[v]data to append#9181richsalz wants to merge 3 commits intoopenssl:masterfrom richsalz:vdata-append
richsalz wants to merge 3 commits intoopenssl:masterfrom
richsalz:vdata-append
Conversation
The "add error data" functions now append to the current error. Add a test for this. Cleanup some of the ERR_put functions. In the FIPS module, always append "(in the FIPS module)" to any errors.
levitte
requested changes
Jun 18, 2019
levitte
approved these changes
Jun 18, 2019
levitte
added
the
approval: review pending
levitte
approved these changes
Jun 18, 2019
bernd-edlinger
approved these changes
Jun 18, 2019
Member
you could use |
Contributor
Author
|
yes, but i was more concerned about the OSD stuff going and resurrecting. |
levitte
added
approval: done
Member
|
Merged. 8908d18 Change ERR_add_error_[v]data to append |
levitte
pushed a commit
that referenced
this pull request
Jun 18, 2019
The "add error data" functions now append to the current error. Add a test for this. Cleanup some of the ERR_put functions. In the FIPS module, always append "(in the FIPS module)" to any errors. Reviewed-by: Bernd Edlinger <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #9181)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "add error data" functions now append to the current error.
Add a test for this, and update the documentation.
Cleanup some of the ERR_put functions.
In the FIPS module, always append "(in the FIPS module)" to any errors.
This replaces #8887. Ping @levitte.