Move asm source file specifications to their respective build.info#9166
Move asm source file specifications to their respective build.info#9166levitte wants to merge 24 commits intoopenssl:masterfrom
Conversation
|
This looks massive if you look at all changes at the same time. I recommend looking at this a commit at a time. |
|
@MouriNaruto, you may be interested in this, as it solves the problem with having ( |
levitte
force-pushed
the
move-asm-source-specs
branch
from
243516d to
2ba6e9a
Compare
|
That was big but fairly straightforward to understand. Nice job cleaning this up! |
levitte
force-pushed
the
move-asm-source-specs
branch
2 times, most recently
from
98b5948 to
b464a09
Compare
|
Some of the Travis failure are not relevant for this PR. Fixing PR is: (more may come) |
levitte
force-pushed
the
move-asm-source-specs
branch
3 times, most recently
from
99ec5a5 to
2b8d086
Compare
…rences This will allow building variables on other variables, and to have conditions based on variable contents.
As preparation for moving uplink file specs to build.info files, we must make sure there is still some base information to help select the correct files.
This file information was hidden in config target files, when they should really be part of build.info like any other file we build from. With build.info variables, the task became much easier. We take the opportunity to move apps_init_src and apps_aux_src to apps/build.info as well, and to clean up apps/build.info.
As preparation for moving asm file specs to build.info files, we must make sure there is still some base information to help select the correct files.
Also took away the internal 'debug-linux-ia32-aes' config target, as it's broken (refers to files that no longer exist).
|
|
||
| - UWP targets only support building the static and dynamic libraries. | ||
|
|
||
| - The "no-uplink" must be given in the "Configure" script. |
There was a problem hiding this comment.
I missed the bit where you disable uplink for UWP. Where is it?
There was a problem hiding this comment.
That's actually already in place:
openssl/Configurations/50-win-onecore.conf
Line 101 in 65dc5c3
openssl/Configurations/50-win-onecore.conf
Line 110 in 65dc5c3
So I really didn't have to do anything with that, just ensure that it actually works.
|
Merged. 30478c9 Configure: final cleanup of asm related things |
…rences This will allow building variables on other variables, and to have conditions based on variable contents. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
As preparation for moving uplink file specs to build.info files, we must make sure there is still some base information to help select the correct files. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
This file information was hidden in config target files, when they should really be part of build.info like any other file we build from. With build.info variables, the task became much easier. We take the opportunity to move apps_init_src and apps_aux_src to apps/build.info as well, and to clean up apps/build.info. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
As preparation for moving asm file specs to build.info files, we must make sure there is still some base information to help select the correct files. Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Also took away the internal 'debug-linux-ia32-aes' config target, as it's broken (refers to files that no longer exist). Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
Remove the *_asm templates in Configurations/00-base-templates.conf, all attempts to inherit them, and the asm() perl function. [extended tests] Reviewed-by: Matt Caswell <[email protected]> (Merged from #9166)
3 participants
Now that we have variables in build.info files, it's easier to specify CPU architecture specific files to be compiled conditionally. There are a few minor adjustments needed to variable processing (i.e. the ability to use variables in conditions, and to expand variable in values for variables.
This way, we have all source files consistently presented in the build.info files they belong with, so we don't have some information in
Configurations/00-base-templates.conf(orConfigurations/10-main.conffor c64xplus), some inConfigurebut their generators in the respective build.info files.