Skip to content

Comments

Fix S390/PPC build for sha providers#9164

Closed
slontis wants to merge 2 commits intoopenssl:masterfrom
slontis:prov_sha_s390_fixes
Closed

Fix S390/PPC build for sha providers#9164
slontis wants to merge 2 commits intoopenssl:masterfrom
slontis:prov_sha_s390_fixes

Conversation

@slontis
Copy link
Member

@slontis slontis commented Jun 14, 2019

Added missing assembler for fips provider + fixed small compile issues.

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis slontis added the branch: master Applies to master branch label Jun 14, 2019
@slontis slontis changed the title Fix S390 build for sha3 providers Fix S390/PPC build for sha3 providers Jun 15, 2019
@slontis slontis changed the title Fix S390/PPC build for sha3 providers Fix S390/PPC build for sha providers Jun 15, 2019
@levitte
Copy link
Member

levitte commented Jun 17, 2019

I forgot about this when I submitted #9168 earlier today... which partially did the same thing as you did.

@levitte
Copy link
Member

levitte commented Jun 25, 2019

Did this get merged?

@slontis
Copy link
Member Author

slontis commented Jun 25, 2019

No @p-steuer did a smaller commit that just had the sha3 changes.. That is all that is needed right?

@slontis
Copy link
Member Author

slontis commented Jun 25, 2019

#9236 has been merged.

@levitte
Copy link
Member

levitte commented Jun 25, 2019

Yeah OK.
I saw the comment in #9236 after writing the comment above...

@slontis
Copy link
Member Author

slontis commented Jun 25, 2019

Yeah I should have added a comment here.. thanks.

@p-steuer
Copy link
Member

I somehow missed this PR. You can always ping me for s390 stuff.

@levitte
Copy link
Member

levitte commented Jun 25, 2019

Heh, seems we are three-four looking at s390x stuff... Maybe we should talk with each other 😉

@slontis
Copy link
Member Author

slontis commented Jun 25, 2019

@p-steuer will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch: master Applies to master branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants