CMS: Adding signers should gen a content type attribute#8944
Closed
slontis wants to merge 4 commits intoopenssl:masterfrom
Closed
CMS: Adding signers should gen a content type attribute#8944slontis wants to merge 4 commits intoopenssl:masterfrom
slontis wants to merge 4 commits intoopenssl:masterfrom
Conversation
slontis
changed the title
Member
Author
|
#8117 needs to be merged for verify -cades to work after -resign is used. |
FdaSilvaYY
reviewed
May 25, 2019
slontis
changed the title
mattcaswell
added
branch: 1.1.1
mattcaswell
requested changes
May 28, 2019
Member
Author
|
Last commit contains the changes + updated commit messages |
Fixes openssl#8923 Found using the openssl cms -resign option. This uses an alternate path to do the signing which was not adding the required signed attribute content type. The content type attribute should always exist since it is required is there are any signed attributes. As the signing time attribute is always added in code, the content type attribute is also required. The CMS_si_check_attributes() method adds validity checks for signed and unsigned attributes e.g. The message digest attribute is a signed attribute that must exist if any signed attributes exist, it cannot be an unsigned attribute and there must only be one instance containing a single value.
mattcaswell
approved these changes
May 29, 2019
mattcaswell
added
the
approval: done
levitte
pushed a commit
that referenced
this pull request
Jun 3, 2019
Fixes #8923 Found using the openssl cms -resign option. This uses an alternate path to do the signing which was not adding the required signed attribute content type. The content type attribute should always exist since it is required is there are any signed attributes. As the signing time attribute is always added in code, the content type attribute is also required. The CMS_si_check_attributes() method adds validity checks for signed and unsigned attributes e.g. The message digest attribute is a signed attribute that must exist if any signed attributes exist, it cannot be an unsigned attribute and there must only be one instance containing a single value. Reviewed-by: Matt Caswell <[email protected]> (Merged from #8944)
levitte
pushed a commit
that referenced
this pull request
Jun 3, 2019
Fixes #8923 Found using the openssl cms -resign option. This uses an alternate path to do the signing which was not adding the required signed attribute content type. The content type attribute should always exist since it is required is there are any signed attributes. As the signing time attribute is always added in code, the content type attribute is also required. The CMS_si_check_attributes() method adds validity checks for signed and unsigned attributes e.g. The message digest attribute is a signed attribute that must exist if any signed attributes exist, it cannot be an unsigned attribute and there must only be one instance containing a single value. Reviewed-by: Matt Caswell <[email protected]> (Merged from #8944) (cherry picked from commit 19e512a)
Member
Author
|
Merged to master and 1_1_1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8923
Found using the openssl cms -resign option.
This uses an alternate path to do the signing which was not adding the required signed attribute
content type. This attribute should always exist since it is required is there are any signed attributes.
As the signing time attribute is always added in code, then the content type attribute is also always required.
Checklist