Add a legacy provider and put MD2 in it#8541
Closed
mattcaswell wants to merge 3 commits intoopenssl:masterfrom
Closed
Add a legacy provider and put MD2 in it#8541mattcaswell wants to merge 3 commits intoopenssl:masterfrom
mattcaswell wants to merge 3 commits intoopenssl:masterfrom
Conversation
Member
It took me a few reads of the commit before I got it. Good catch!!! |
paulidale
reviewed
Mar 21, 2019
providers/legacy/legacyprov.c
Outdated
Contributor
There was a problem hiding this comment.
legacy=yes
This will require a change to crypto/property/property_parse.c to permit the legacy property name.
levitte
reviewed
Mar 21, 2019
Member
|
@mattcaswell, don't forget this one. |
When we attempt to fetch a method with a given NID we will ask the providers for it if we don't already know about it. During that process we may be told about other methods with a different NID. We need to make sure we don't confuse the two.
mattcaswell
force-pushed
the
legacy-skeleton
branch
from
5d575a6 to
f533f69
Compare
mattcaswell
changed the title
Member
Author
|
Rebased and updated with fixes for the comments above. Also this is now out of WIP. |
levitte
requested changes
Apr 5, 2019
Member
Author
|
I updated the internal docs as requested. Fixup commit pushed. |
levitte
approved these changes
Apr 8, 2019
Member
Author
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Apr 9, 2019
When we attempt to fetch a method with a given NID we will ask the providers for it if we don't already know about it. During that process we may be told about other methods with a different NID. We need to make sure we don't confuse the two. Reviewed-by: Richard Levitte <[email protected]> (Merged from #8541)
levitte
pushed a commit
that referenced
this pull request
Apr 9, 2019
Reviewed-by: Richard Levitte <[email protected]> (Merged from #8541)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #8513. It creates the legacy provider and implements MD2 within it.
While implementing this I discovered a bug in the fetching code which I also fixed. When we attempt to fetch a method with a given NID we will ask the providers for it if we don't already know about it. During that process we may be told about other methods with a different NID. We need to make sure we don't confuse the two.