Add a default provider and implement SHA256 in it#8513
Closed
mattcaswell wants to merge 9 commits intoopenssl:masterfrom
Closed
Add a default provider and implement SHA256 in it#8513mattcaswell wants to merge 9 commits intoopenssl:masterfrom
mattcaswell wants to merge 9 commits intoopenssl:masterfrom
Conversation
levitte
reviewed
Mar 18, 2019
mattcaswell
force-pushed
the
provider-skeletons
branch
from
adbdead to
7b65394
Compare
Member
Author
|
Rebased now that #8341 went in. |
2 tasks
Member
Author
mattcaswell
force-pushed
the
provider-skeletons
branch
from
7b65394 to
2430132
Compare
levitte
requested changes
Mar 19, 2019
richsalz
reviewed
Mar 19, 2019
mattcaswell
force-pushed
the
provider-skeletons
branch
from
a749a0c to
3218b0e
Compare
mattcaswell
changed the title
Member
Author
|
I've rebased this and removed the dependency on #8519 (which got closed without merge). So this PR is now completely standalone. I've taken it out of WIP. Please take a look. |
paulidale
approved these changes
Mar 20, 2019
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
One thing that needs to be fixed -- prototype removal in providers/default/defltprov.c.
The rest are suggestions to take or leave.
Member
Author
|
Fixup commits pushed. @paulidale please can you reconfirm? |
This was referenced Mar 20, 2019
paulidale
added
the
approval: done
Contributor
|
AppVeyor failure isn't relevant. |
Member
|
I restarted the failed appveyor build |
Member
Author
|
Appveyor passed this time. |
Member
Author
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Mar 21, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8513)
levitte
pushed a commit
that referenced
this pull request
Mar 21, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8513)
levitte
pushed a commit
that referenced
this pull request
Mar 21, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8513)
levitte
pushed a commit
that referenced
this pull request
Mar 21, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8513)
levitte
pushed a commit
that referenced
this pull request
Mar 21, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8513)
levitte
pushed a commit
that referenced
this pull request
Mar 21, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8513)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is marked as WIP because it still needs tests and documentation. It is also built on the commits in #8341 and #8480.
This runs through "make test" successfully using the default provider implementation of SHA256 where applicable. If engines are involved or we are invoking the EVP_Digest* functions as part of an EVP_DigestSign* operation then we fallback to the legacy handling.