Don't fail when tracing is disabled#8475
Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
Closed
Conversation
When tracing is disabled, don't generate errors, especially during init. Instead, just pretend the everything is fine.
1 task
mspncp
approved these changes
Mar 14, 2019
Member
|
Either here or in #8474 , should we add targets in the CI configuration to try both with and without TRACE enabled? |
Member
Author
|
That's more of a run-checker thing. We can't load the CIs with too many things, they simply can't take the load (we've seen it before). |
Member
Author
|
Submitted a PR for it: openssl/tools#37 |
Member
Author
|
Merged. d33d761 Don't fail when tracing is disabled |
levitte
added a commit
that referenced
this pull request
Mar 14, 2019
When tracing is disabled, don't generate errors, especially during init. Instead, just pretend the everything is fine. Reviewed-by: Matthias St. Pierre <[email protected]> (Merged from #8475)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tracing is disabled, don't generate errors, especially during
init. Instead, just pretend the everything is fine.