Configure: disable new trace api by default#8474
Closed
mspncp wants to merge 1 commit intoopenssl:masterfrom
Closed
Configure: disable new trace api by default#8474mspncp wants to merge 1 commit intoopenssl:masterfrom
mspncp wants to merge 1 commit intoopenssl:masterfrom
Conversation
Member
|
I agree with this approach. However I think we should leave this PR open for 24 hours for @levitte and others to comment. |
Contributor
Author
|
Sure, I'll wait for the discussion. I'm not in a hurry. |
mspncp
force-pushed
the
pr-config-disable-trace
branch
from
a20dcbd to
cd88884
Compare
Contributor
Author
|
All commits squashed. Ready for review and comments. |
mspncp
force-pushed
the
pr-config-disable-trace
branch
3 times, most recently
from
f7a410c to
775bce0
Compare
Member
|
I'm fine with these changes. However, Travis is having a fit... |
Member
|
#8475 should fix the Travis issue |
Contributor
Author
|
Ok, I'll rebase when #8475 is merged. |
Member
|
#8475 is now merged |
mspncp
force-pushed
the
pr-config-disable-trace
branch
from
775bce0 to
6007e8f
Compare
Contributor
Author
|
Rebased without changes to get the bugfix from #8475. |
Contributor
Author
Arghh! Wrong pull request :-/ I shouldn't do too many things in parallel. |
mspncp
added
approval: done
levitte
pushed a commit
that referenced
this pull request
Mar 14, 2019
Fixes #8472 Reviewed-by: Richard Levitte <[email protected]> (Merged from #8474)
Contributor
Author
|
Merged, thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8472
Checklist