Closed
Conversation
With enough warning flags, compilers complain when a non-static function hasn't been properly declared...
Again, compilers that don't like them being undeclared...
TEST_ulong_eq was used previously because TEST_double_eq didn't exist at the time.
levitte
force-pushed
the
fis-params_test-20190313
branch
from
f2003c8 to
7145e85
Compare
Member
Author
|
I'll just wait for the CIs to confirm as well... |
romen
added
the
approval: done
Member
Author
levitte
added a commit
that referenced
this pull request
Mar 13, 2019
With enough warning flags, compilers complain when a non-static function hasn't been properly declared... Reviewed-by: Nicola Tuveri <[email protected]> (Merged from #8469)
levitte
added a commit
that referenced
this pull request
Mar 13, 2019
Again, compilers that don't like them being undeclared... Reviewed-by: Nicola Tuveri <[email protected]> (Merged from #8469)
levitte
added a commit
that referenced
this pull request
Mar 13, 2019
TEST_ulong_eq was used previously because TEST_double_eq didn't exist at the time. Reviewed-by: Nicola Tuveri <[email protected]> (Merged from #8469)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
79c0b33 test/params_test.c: make construct_api_params() static
9eaf623 test/params_test.c: make more global variables static
f2003c8 test/params_test.c: use TEST_double_eq to check doubles