test/params_test.c: Add higher level parameter testing#8396
Closed
levitte wants to merge 4 commits intoopenssl:masterfrom
Closed
test/params_test.c: Add higher level parameter testing#8396levitte wants to merge 4 commits intoopenssl:masterfrom
levitte wants to merge 4 commits intoopenssl:masterfrom
Conversation
Member
Author
|
@paulidale, @richsalz, ask and you shall receive 😉 |
Contributor
|
I think this is worth having, but seeing it as sample code is a bad idea in my view. |
Member
Author
|
My thought is that it can be extended with OSSL_PARAM arrays and functions that use other methods (such as your API, or @paulidale's). What I've written is designed to work with what currently exists in master. |
Contributor
|
Yes, I understand that. As a functional or unit test, great. As a "way to use" the PARAM stuff, I disagree. |
Member
Author
|
So, errrr, how did you intend to use them? |
Contributor
|
Via the higher-level API's in the two PR's. |
Member
Author
|
I will repeat: I have made this program in such a way that setup, setting and getting with those APIs can easily be added. |
Contributor
|
Yes, I know. I understand. I guess it's worthwhile to look at the two API's and see if they're doing things this way. I know #8377 isn't. Again, that isn't to say there is anything else bad with this. More tests, the better. |
This was referenced Mar 4, 2019
EXPERIMENTAL FOR DISPLAY ONLY: combine 'Native C types for OSSL_PARAM' with test/params_test.c
#8398
Closed
test/params_test.c is a program that tries to mimic how a provider and an application would or could handle OSSL_PARAM arrays. For the moment, this program tests a very raw way of handling OSSL_PARAM arrays. It is, however, written in a way that will hopefully make it possible to extend with other methods as APIs arise, and to set up test cases where a "provider" handles the array one way while the "application" handles it another way.
Member
Author
|
Now that a params API has been selected and merged, this test is updated with constructions and checks using that API. |
paulidale
approved these changes
Mar 13, 2019
Member
Author
levitte
added a commit
that referenced
this pull request
Mar 13, 2019
test/params_test.c is a program that tries to mimic how a provider and an application would or could handle OSSL_PARAM arrays. For the moment, this program tests a very raw way of handling OSSL_PARAM arrays. It is, however, written in a way that will hopefully make it possible to extend with other methods as APIs arise, and to set up test cases where a "provider" handles the array one way while the "application" handles it another way. Reviewed-by: Paul Dale <[email protected]> (Merged from #8396)
levitte
added a commit
that referenced
this pull request
Mar 13, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8396)
levitte
added a commit
that referenced
this pull request
Mar 13, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8396)
Member
|
Uhm, I'm seeing compilation errors with ccache clang-3.9 -I. -Iinclude -Iapps/include -pthread -m64 -Wa,--noexecstack -Qunused-arguments -rdynamic -Wall -O0 -g -g -DDEBUG_UNUSED -DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wswitch -Wsign-compare -Wshadow -Wformat -Wtype-limits -Wundef -Werror -Wmissing-prototypes -Wstrict-prototypes -Wswitch-default -Wno-parentheses-equality -Wno-language-extension-token -Wno-extended-offsetof -Wconditional-uninitialized -Wincompatible-pointer-types-discards-qualifiers -Wno-unknown-warning-option -Wmissing-variable-declarations -Qunused-arguments -MMD -MF
test/params_test-bin-params_test.d.tmp -MT test/params_test-bin-params_test.o -c -o test/params_test-bin-params_test.o test/params_test.c
test/params_test.c:390:13: error: no previous prototype for function 'construct_api_params' [-Werror,-Wmissing-prototypes]
OSSL_PARAM *construct_api_params(void)
^
test/params_test.c:417:23: error: no previous extern declaration for non-static variable 'raw_params' [-Werror,-Wmissing-variable-declarations]
struct param_owner_st raw_params = {
^
test/params_test.c:421:23: error: no previous extern declaration for non-static variable 'api_params' [-Werror,-Wmissing-variable-declarations]
struct param_owner_st api_params = {
^
test/params_test.c:472:35: error: implicit conversion from 'double' to 'unsigned long' changes value from 47.11 to 47 [-Werror,-Wliteral-conversion]
|| !TEST_ulong_eq(app_p2, app_p2_init) /* Should remain untouched */
~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
test/params_test.c:319:21: note: expanded from macro 'app_p2_init'
#define app_p2_init 47.11 /* Another random number */
^~~~~
test/testutil.h:397:76: note: expanded from macro 'TEST_ulong_eq'
# define TEST_ulong_eq(a, b) test_ulong_eq(__FILE__, __LINE__, #a, #b, a, b)
~~~~~~~~~~~~~ ^
test/params_test.c:494:46: error: implicit conversion from 'double' to 'unsigned long' changes value from 6.283 to 6 [-Werror,-Wliteral-conversion]
|| !TEST_ulong_eq(sneakpeek->p2, p2_init) /* Should remain untouched */
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
test/params_test.c:75:17: note: expanded from macro 'p2_init'
#define p2_init 6.283 /* Magic number */
^~~~~
test/testutil.h:397:76: note: expanded from macro 'TEST_ulong_eq'
# define TEST_ulong_eq(a, b) test_ulong_eq(__FILE__, __LINE__, #a, #b, a, b)
~~~~~~~~~~~~~ ^
test/params_test.c:515:35: error: implicit conversion from 'double' to 'unsigned long' changes value from 47.11 to 47 [-Werror,-Wliteral-conversion]
|| !TEST_ulong_eq(app_p2, app_p2_init) /* Should remain untouched */
~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
test/params_test.c:319:21: note: expanded from macro 'app_p2_init'
#define app_p2_init 47.11 /* Another random number */
^~~~~
test/testutil.h:397:76: note: expanded from macro 'TEST_ulong_eq'
# define TEST_ulong_eq(a, b) test_ulong_eq(__FILE__, __LINE__, #a, #b, a, b)
~~~~~~~~~~~~~ ^
6 errors generated.
Makefile:15536: recipe for target 'test/params_test-bin-params_test.o' failed
make[1]: *** [test/params_test-bin-params_test.o] Error 1 |
Member
Author
|
Yeah, see #8469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/params_test.c is a program that tries to mimic how a provider and
an application would or could handle OSSL_PARAM arrays.
For the moment, this program tests a very raw way of handling
OSSL_PARAM arrays. It is, however, written in a way that will
hopefully make it possible to extend with other methods as APIs arise,
and to set up test cases where a "provider" handles the array one way
while the "application" handles it another way.