deps: add s390 asm rules for OpenSSL-1.1.1 #8351
Conversation
openssl-machine
added
the
hold: cla required
|
Hi, we are floating this patch in Node.js, are you interested in accepting it upstream? Most of the changes in it are already on master, but came in with large cleanups, I think that's why they didn't get backported to 1.1.1. The only line not on master is: I can PR that to master if its wanted. |
|
@shigeki to upstream this, if acceptable, it might need a CLA from you, unless OpenSSL is comfortable calling it trivial, since its a couple lines of configuration, not code. |
|
@levitte should I open a PR to master for the one-liner I show in the diff above? Full disclosure: I'm just shovelling code between repos, I've no idea how it works, so maybe the one-line isn't necessary. |
|
I have access to a s390, so I can check. |
|
The INCLUDE suggested for master isn't necessary, which had me looking at 1.1.1 as well. |
|
So about that CLA thing... I'm unsure if this can be called trivla from a copyright perspective, so I do believe we need a signed CLA from @shigeki . |
Generate asm files with Makefile rules. From: - nodejs/node@0d9a86c
|
("trivial" from a copyright perspective and from a technical perspective is hugely different, FYI. I do agree that this is trivial from a technical perspective, but that's not what counts with regards to CLAs) |
|
@sam-github Thanks for submitting this on behalf of me. @levitte I sent my ICLA. Please make sure that you received it. |
|
CLA received. Close/reopen to kick CLA bot. |
openssl-machine
removed
the
hold: cla required
levitte
added
approval: review pending
|
Checks all passed, including CLA. Thanks @shigeki |
bernd-edlinger
added
approval: done
Generate asm files with Makefile rules. From: - nodejs/node@0d9a86c Reviewed-by: Bernd Edlinger <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #8351)
|
Merged. de4fb43 deps: add s390 asm rules for OpenSSL-1.1.1 |
|
Thank you! |
Patching the s390 asm rules is no longer required. See: openssl/openssl#8351
Patching the s390 asm rules is no longer required. See: openssl/openssl#8351
Patching the s390 asm rules is no longer required. See: openssl/openssl#8351 PR-URL: nodejs#28211 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Patching the s390 asm rules is no longer required. See: openssl/openssl#8351 PR-URL: #28211 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Patching the s390 asm rules is no longer required. See: openssl/openssl#8351 PR-URL: #28211 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Patching the s390 asm rules is no longer required. See: openssl/openssl#8351 PR-URL: #28212 Reviewed-By: Beth Griggs <[email protected]>
7 participants
Generate asm files with Makefile rules.
From:
Checklist