Replumbing: Add constructor of libcrypto internal method structures#8340
Closed
levitte wants to merge 3 commits intoopenssl:masterfrom
Closed
Replumbing: Add constructor of libcrypto internal method structures#8340levitte wants to merge 3 commits intoopenssl:masterfrom
levitte wants to merge 3 commits intoopenssl:masterfrom
Conversation
Member
Author
2 tasks
levitte
force-pushed
the
300-core-fetch
branch
5 times, most recently
from
7a67e89 to
610a5ae
Compare
paulidale
reviewed
Mar 4, 2019
levitte
force-pushed
the
300-core-fetch
branch
2 times, most recently
from
a93dac2 to
c1f3e41
Compare
Member
Author
|
#8287 is now merged. I've rebased this and squashed all fixups |
Member
Author
|
I know that @paulidale approved this a while ago, but I think we do need a final review now that it doesn't depend on any other PR any more. |
paulidale
approved these changes
Mar 12, 2019
Contributor
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
A couple of documentation nit.
crypto/core_fetch.c
Outdated
Contributor
There was a problem hiding this comment.
A nice mix or names using underscores and not...
levitte
changed the title
This queries the provider for its available functionality (unless a matching method structured is already cached, in which case that's used instead), and creates method structure with the help of a passed constructor. The result is cached if the provider allows it (or if caching is forced).
Member
Author
|
|
Member
Author
levitte
added a commit
that referenced
this pull request
Mar 12, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8340)
levitte
added a commit
that referenced
this pull request
Mar 12, 2019
Reviewed-by: Paul Dale <[email protected]> (Merged from #8340)
levitte
added a commit
that referenced
this pull request
Mar 12, 2019
This queries the provider for its available functionality (unless a matching method structured is already cached, in which case that's used instead), and creates method structure with the help of a passed constructor. The result is cached if the provider allows it (or if caching is forced). Reviewed-by: Paul Dale <[email protected]> (Merged from #8340)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This queries the provider for its available functionality (unless a
matching method structured is already cached, in which case that's
used instead), and creates method structure with the help of a passed
constructor. The result is cached if the provider allows it (or if
caching is forced).
Checklist