Skip to content

Travis CI: Use flake8 to find Python syntax errors or undefined names #7410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cclauss wants to merge 1 commit into from
Closed

Travis CI: Use flake8 to find Python syntax errors or undefined names #7410

cclauss wants to merge 1 commit into from

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 16, 2018

In Travis CI, add a Python linting step that run flake8 tests in Travis CI to find syntax errors and undefined names.

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.

  • F821: undefined name name
  • F822: undefined name name in __all__
  • F823: local variable name referenced before assignment
  • E901: SyntaxError or IndentationError
  • E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
Checklist
  • documentation is added or updated
  • tests are added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Oct 16, 2018
@cclauss cclauss mentioned this pull request Oct 16, 2018
Closed
cclauss pushed a commit to cclauss/openssl that referenced this pull request Oct 16, 2018
print() is a function in Python 3
e4e53e4 
CLA: trivial

Discovered via openssl#7410 @ https://travis-ci.org/openssl/openssl/jobs/442003489#L440
@mspncp
Copy link
Contributor

mspncp commented Oct 16, 2018

Not sure whether this change qualifies as 'trivial'. However, one could be hair-splitting and argument that it is a contribution to the ci and not a contribution to OpenSSL. Since the empty set qualifies as 'trivial', the cla rules would be satisfied. ;-)

@cclauss
Copy link
Contributor Author

cclauss commented Oct 16, 2018

Let's wait until the print() PR lands and this PR's Travis tests pass.

@mspncp
Copy link
Contributor

mspncp commented Oct 16, 2018 •
edited
Loading

Ok, let's wait for the other pull request. A propos: do you have yet more pull requests in your queue? If yes, it might be worthwile to send us your signed CLA forehanded, regardless of whether these two are considered trivial or not.

(Since If you are using your company email address, both an Individual CLA and a Corporate CLA will be necessary; for details, see https://www.openssl.org/policies/cla.html)

Update: if that's your provider, not your employer then of course no CCLA is necessary ;-)

levitte pushed a commit that referenced this pull request Oct 17, 2018
@mspncp
print() is a function in Python 3
391f76f 
CLA: trivial

Discovered via #7410 @ https://travis-ci.org/openssl/openssl/jobs/442003489#L440

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from #7403)

(cherry picked from commit 83e4533)
levitte pushed a commit that referenced this pull request Oct 17, 2018
@mspncp
print() is a function in Python 3
83e4533 
CLA: trivial

Discovered via #7410 @ https://travis-ci.org/openssl/openssl/jobs/442003489#L440

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from #7403)
Travis CI: Use flake8 to find Python syntax errors or undefined names
b8fdfd4 
CLA: trivial

In Travis CI, add a Python linting step that run [flake8](http://flake8.pycqa.org) tests in Travis CI to find syntax errors and undefined names.

__E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Oct 17, 2018
@cclauss
Copy link
Contributor Author

cclauss commented Oct 17, 2018

@mspncp Looks good. No other PRs in my queue.

@mspncp mspncp added branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) approval: review pending This pull request needs review by a committer labels Oct 17, 2018
@cclauss
Copy link
Contributor Author

cclauss commented Nov 19, 2018

@paulidale Could I please get your review on this PR now that #7409 has landed?

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 19, 2018
@paulidale
Copy link
Contributor

paulidale commented Nov 19, 2018

Apologies for missing this one.

@mspncp
Copy link
Contributor

mspncp commented Nov 20, 2018

@paulidale I'll do the merge (in fact, I already did it, but the repo is currently frozen).

@mspncp mspncp self-assigned this Nov 20, 2018
@mspncp
Copy link
Contributor

mspncp commented Nov 20, 2018

Editorial note: I did some minimal editing of the commit message:

  • shorten long lines
  • remove markdown link for 'flake8'
    Travis CI: Use flake8 to find Python syntax errors or undefined names
    
    CLA: trivial
    
    In Travis CI, add a Python linting step that runs flake8 tests in Travis CI
    to find syntax errors and undefined names. (http://flake8.pycqa.org)
    
    __E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can halt
    the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are
    merely "style violations" -- useful for readability but they do not effect
    runtime safety.
    
    * F821: undefined name `name`
    * F822: undefined name `name` in `__all__`
    * F823: local variable name referenced before assignment
    * E901: SyntaxError or IndentationError
    * E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

@paulidale
Copy link
Contributor

paulidale commented Nov 20, 2018

Thanks @mspncp the frozen repository is what stopped me doing it.

@mspncp
Copy link
Contributor

mspncp commented Nov 20, 2018

Ah, o.k. I thought you had left it for me because I was the first one to approve. Never mind, it's too late for 1.1.1a now anyway.

levitte pushed a commit that referenced this pull request Nov 20, 2018
@mspncp
Travis CI: Use flake8 to find Python syntax errors or undefined names
2a6f57b 
CLA: trivial

In Travis CI, add a Python linting step that runs flake8 tests in Travis CI
to find syntax errors and undefined names. (http://flake8.pycqa.org)

__E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can halt
the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are
merely "style violations" -- useful for readability but they do not effect
runtime safety.

* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from #7410)
levitte pushed a commit that referenced this pull request Nov 20, 2018
@mspncp
Travis CI: Use flake8 to find Python syntax errors or undefined names
e587e8e 
CLA: trivial

In Travis CI, add a Python linting step that runs flake8 tests in Travis CI
to find syntax errors and undefined names. (http://flake8.pycqa.org)

__E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can halt
the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are
merely "style violations" -- useful for readability but they do not effect
runtime safety.

* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from #7410)

(cherry picked from commit 2a6f57b)
@mspncp
Copy link
Contributor

mspncp commented Nov 20, 2018

Merged, thank you!

@mspncp mspncp closed this Nov 20, 2018
@mspncp mspncp added this to the 1.1.1b milestone Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulidale paulidale paulidale approved these changes

+1 more reviewer

@mspncp mspncp mspncp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mspncp mspncp

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL)

Projects

None yet

Milestone

1.1.1b

Development

Successfully merging this pull request may close these issues.

4 participants

@cclauss @mspncp @paulidale @openssl-machine