Coverity : various fixup by FdaSilvaYY · Pull Request #7359 · openssl/openssl

FdaSilvaYY · 2018-10-07T19:18:45Z

Fix:
CID 1338183 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS)
CID 1371691 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS)
CID 1371692 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS)
and a recently introduced one:
CID 1440002 (#1 of 1): Use after free (USE_AFTER_FREE)

Checklist

documentation is added or updated
tests are added or updated

FdaSilvaYY · 2018-10-08T18:38:23Z

Fix and rebased; CI's are green !
Ready for review ;)
The crypto/asn1 changes can be merged into 1.1.1 branch too.

mspncp · 2018-10-08T18:40:27Z

Just two typos in the commit messages, which I happened to find en passant:

Coverty -> Coverity (2 instances)
eror -> error

mattcaswell · 2018-10-09T08:37:51Z

The crypto/asn1 changes can be merged into 1.1.1 branch too.

Doesn't that also apply to the ocsp change too?

FdaSilvaYY · 2018-10-09T10:12:26Z

The crypto/asn1 changes can be merged into 1.1.1 branch too.

Doesn't that also apply to the ocsp change too?

You are right : the 1st ocsp mem leak fix was merged to 1.1.1 too ;)
so the whole PR can be labeled maser and 1.1.1 .

BTW, is Coverity scanning the master branch only, or not ?

FdaSilvaYY · 2018-10-26T17:29:29Z

Ping @openssl /commiters.
CI (with extended tests) are green, good for review !

FdaSilvaYY · 2018-11-05T19:52:01Z

Ping @mattcaswell , @mspncp : is there something more to do ?

crypto/asn1/a_sign.c

crypto/asn1/a_verify.c

FdaSilvaYY · 2018-11-18T10:35:31Z

Ping @mattcaswell , @mspncp : IMHO, issues are now fixed.

crypto/asn1/a_sign.c

FdaSilvaYY · 2018-12-07T07:55:22Z

Ping @openssl : fixed, and rebased.
Travis is failing on some 'external' tests, because of last changes on Master.

mspncp · 2018-12-07T07:56:10Z

Sorry @FdaSilvaYY for letting you wait so long. I'll have a look at it today or tomorrow.

crypto/asn1/a_sign.c

CID 1440002 (#1 of 1): Use after free (USE_AFTER_FREE) Not a deadly error, because error was just before app exit.

Call to i2d method returns an int value. Fix: CID 1338183 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) CID 1371691 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) CID 1371692 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) [extended tests]

FdaSilvaYY · 2018-12-12T22:22:43Z

Ping @openssl : please take a look ;)

crypto/asn1/a_sign.c

CID 1440002 (#1 of 1): Use after free (USE_AFTER_FREE) Not a deadly error, because error was just before app exit. Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #7359)

Call to i2d method returns an int value. Fix: CID 1338183 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) CID 1371691 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) CID 1371692 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) [extended tests] Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #7359)

CID 1440002 (#1 of 1): Use after free (USE_AFTER_FREE) Not a deadly error, because error was just before app exit. Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #7359) (cherry picked from commit 39fc4c1)

Call to i2d method returns an int value. Fix: CID 1338183 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) CID 1371691 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) CID 1371692 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) [extended tests] Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #7359) (cherry picked from commit da84249)

mspncp · 2018-12-22T17:16:55Z

Merged, thank you and sorry for the delay!

master
da84249 Coverity fix in some crypto/asn1 code
39fc4c1 Coverity fix in apps/oscp

1.1.1
7d55056 Coverity fix in some crypto/asn1 code
9318545 Coverity fix in apps/oscp

FdaSilvaYY changed the title ~~Coverty : fews fixup~~ Coverty : small fixup Oct 7, 2018

FdaSilvaYY force-pushed the coverty/fixup branch from a2ef99a to 9bfb297 Compare October 7, 2018 19:47

FdaSilvaYY changed the title ~~Coverty : small fixup~~ Coverty : various fixup Oct 7, 2018

FdaSilvaYY force-pushed the coverty/fixup branch from 9bfb297 to 2efb117 Compare October 7, 2018 20:17

openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Oct 8, 2018

FdaSilvaYY force-pushed the coverty/fixup branch from d9f0f8c to 29d1a05 Compare October 8, 2018 18:18

openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Oct 8, 2018

FdaSilvaYY changed the title ~~Coverty : various fixup~~ Coverity : various fixup Oct 8, 2018

FdaSilvaYY force-pushed the coverty/fixup branch from 29d1a05 to 07e310b Compare October 8, 2018 20:45

FdaSilvaYY force-pushed the coverty/fixup branch from 07e310b to ac49587 Compare October 9, 2018 18:07

FdaSilvaYY force-pushed the coverty/fixup branch from ac49587 to 8006507 Compare October 24, 2018 21:27

FdaSilvaYY force-pushed the coverty/fixup branch from 8006507 to d4f5d25 Compare November 2, 2018 22:58

mattcaswell added branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) labels Nov 6, 2018

mattcaswell requested changes Nov 6, 2018

View reviewed changes

crypto/asn1/a_sign.c Outdated Show resolved Hide resolved

crypto/asn1/a_sign.c Outdated Show resolved Hide resolved

crypto/asn1/a_verify.c Outdated Show resolved Hide resolved

FdaSilvaYY force-pushed the coverty/fixup branch 2 times, most recently from 371a55e to c2d1c39 Compare November 17, 2018 18:17

mattcaswell reviewed Nov 19, 2018

View reviewed changes

crypto/asn1/a_sign.c Outdated Show resolved Hide resolved

FdaSilvaYY force-pushed the coverty/fixup branch from c2d1c39 to e82537a Compare November 19, 2018 23:04

FdaSilvaYY force-pushed the coverty/fixup branch from e82537a to 8aff6be Compare December 6, 2018 19:50

FdaSilvaYY mentioned this pull request Dec 7, 2018

Use after free in spawn_loop #7845

Closed

mattcaswell requested changes Dec 7, 2018

View reviewed changes

crypto/asn1/a_sign.c Outdated Show resolved Hide resolved

crypto/asn1/a_sign.c Outdated Show resolved Hide resolved

FdaSilvaYY added 2 commits December 7, 2018 20:30

Coverity fix in apps/oscp

f702d3c

CID 1440002 (#1 of 1): Use after free (USE_AFTER_FREE) Not a deadly error, because error was just before app exit.

FdaSilvaYY force-pushed the coverty/fixup branch from 8aff6be to e7f754e Compare December 7, 2018 19:33

mattcaswell requested changes Dec 13, 2018

View reviewed changes

crypto/asn1/a_sign.c Show resolved Hide resolved

levitte approved these changes Dec 13, 2018

View reviewed changes

mattcaswell approved these changes Dec 14, 2018

View reviewed changes

mattcaswell added the approval: done This pull request has the required number of approvals label Dec 14, 2018

mspncp closed this Dec 22, 2018

mspncp added this to the 1.1.1b milestone Dec 23, 2018

FdaSilvaYY deleted the coverty/fixup branch December 23, 2018 14:23

Uh oh!

Comments

Conversation

FdaSilvaYY commented Oct 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

FdaSilvaYY commented Oct 8, 2018

Uh oh!

mspncp commented Oct 8, 2018

Uh oh!

mattcaswell commented Oct 9, 2018

Uh oh!

FdaSilvaYY commented Oct 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FdaSilvaYY commented Oct 26, 2018

Uh oh!

FdaSilvaYY commented Nov 5, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FdaSilvaYY commented Nov 18, 2018

Uh oh!

Uh oh!

FdaSilvaYY commented Dec 7, 2018

Uh oh!

mspncp commented Dec 7, 2018

Uh oh!

Uh oh!

Uh oh!

FdaSilvaYY commented Dec 12, 2018

Uh oh!

Uh oh!

mspncp commented Dec 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FdaSilvaYY commented Oct 7, 2018 •

edited

Loading

FdaSilvaYY commented Oct 9, 2018 •

edited

Loading